diff --git a/docs/npm_package.md b/docs/npm_package.md index a0823eb80..629a3c952 100644 --- a/docs/npm_package.md +++ b/docs/npm_package.md @@ -64,8 +64,6 @@ using the `include_sources`, `include_transitive_sources`, `include_types`, `inc The two `include*_types` options may cause type-check actions to run, which slows down your development round-trip. -You can pass the Bazel option `--@aspect_rules_js//npm:exclude_types_from_npm_packages` -to override these two attributes for an individual `bazel` invocation, avoiding the type-check. As of rules_js 2.0, the recommended solution for avoiding eager type-checking when linking 1p deps is to link `js_library` or any `JsInfo` producing targets directly without the diff --git a/npm/BUILD.bazel b/npm/BUILD.bazel index 504589e8a..a14584b6c 100644 --- a/npm/BUILD.bazel +++ b/npm/BUILD.bazel @@ -10,12 +10,14 @@ exports_files( # Allows for faster dev roundtrip by excluding type-checking from libraries that are # internally used via npm_package +# TODO(3.0): remove bool_flag( name = "exclude_types_from_npm_packages", build_setting_default = False, visibility = ["//visibility:public"], ) +# TODO(3.0): remove config_setting( name = "exclude_types_from_npm_packages_flag", flag_values = {":exclude_types_from_npm_packages": "true"}, diff --git a/npm/private/npm_package.bzl b/npm/private/npm_package.bzl index 28447e4c5..3e52ce132 100644 --- a/npm/private/npm_package.bzl +++ b/npm/private/npm_package.bzl @@ -195,8 +195,6 @@ def npm_package( The two `include*_types` options may cause type-check actions to run, which slows down your development round-trip. - You can pass the Bazel option `--@aspect_rules_js//npm:exclude_types_from_npm_packages` - to override these two attributes for an individual `bazel` invocation, avoiding the type-check. As of rules_js 2.0, the recommended solution for avoiding eager type-checking when linking 1p deps is to link `js_library` or any `JsInfo` producing targets directly without the