Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example of "differential loading" #193

Open
alexeagle opened this issue Jun 13, 2022 · 1 comment
Open

Example of "differential loading" #193

alexeagle opened this issue Jun 13, 2022 · 1 comment
Labels
example New example or update to existing example

Comments

@alexeagle
Copy link
Member

Translate this example https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/webapp to rules_js
which shows how to create an ESM and ES5 bundle and serve the right one to modern browsers.
@alexeagle
Copy link
Member Author

Started this here: https://github.com/aspect-build/bazel-examples/tree/diff_loading

failing with

ERROR: /Users/alexeagle/Projects/bazel-examples/web_differential_loading/BUILD.bazel:3:21: in directory_path rule //:app_chunks_es5__entry_point:
Traceback (most recent call last):
	File "/private/var/tmp/_bazel_alexeagle/4c631830123360fff233a1c36bdbc895/external/aspect_bazel_lib/lib/private/directory_path.bzl", line 17, column 13, in _directory_path
		fail("expected directory to be a TreeArtifact (ctx.actions.declare_directory) but got {}".format(ctx.file.directory))
Error in fail: expected directory to be a TreeArtifact (ctx.actions.declare_directory) but got <source file node_modules/@babel/cli/store/7.17.10_@[email protected]/dir>

@gregmagolan gregmagolan added the example New example or update to existing example label Aug 3, 2022
@gregmagolan gregmagolan moved this to 📋 Backlog in Open Source Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
example New example or update to existing example
Projects
Open Source
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @gregmagolan