Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pnpm shared-workspace-lockfile=false mode #370

Open
gregmagolan opened this issue Aug 7, 2022 · 0 comments
Open

Support pnpm shared-workspace-lockfile=false mode #370

gregmagolan opened this issue Aug 7, 2022 · 0 comments
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build

Comments

@gregmagolan
Copy link
Member

Tested this in #367 and it is almost supported with existing constructs except that transitive deps of first-party workspace links are not picked up because the information is split across lock files.

Should be relatively easy to create an npm_translate_locks repository rule or macro to make this easy for the end user. Just have to figure out how to pass transitive deps for 1st party workspace links around when the data is split across lock files.

cc @alexeagle @jondlm @sushain97

@gregmagolan gregmagolan added the enhancement New feature or request label Aug 7, 2022
@gregmagolan gregmagolan added this to the 1.1 milestone Aug 7, 2022
@gregmagolan gregmagolan moved this to 📋 Backlog in Open Source Feb 4, 2023
@gregmagolan gregmagolan added the funding needed Contribute to https://opencollective.com/aspect-build label Feb 4, 2023
@gregmagolan gregmagolan removed this from the Performance & Docs milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant