Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document .npmrc registry/auth support in npm_translate_lock docstring #383

Open
alexeagle opened this issue Aug 12, 2022 · 3 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@alexeagle
Copy link
Member

https://docs.npmjs.com/using-private-packages-in-a-ci-cd-workflow#create-and-check-in-a-project-specific-npmrc-file

In practice we probably just have to validate that the Bazel downloader config flag is set, and the downloader config has mirrored the settings from .npmrc.

@alexeagle alexeagle added the enhancement New feature or request label Aug 12, 2022
@pedrobarco
Copy link
Contributor

I think this has been fixed with #475

@alexeagle
Copy link
Member Author

I think we're missing a documentation update to consider it done

@gregmagolan
Copy link
Member

Basic auth support has landed in #623. I think we should just add more color to the npm_translate_lock docstring for the npmrc setting and we can close this one.

@gregmagolan gregmagolan added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jan 24, 2023
@gregmagolan gregmagolan changed the title Support .npmrc registry/auth settings Document .npmrc registry/auth support in npm_translate_lock docstring Jan 24, 2023
@gregmagolan gregmagolan moved this to 🔖 Ready in Open Source Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: On Deck
Development

No branches or pull requests

3 participants