Translations loading fix112

[sebastienserre]

Pull Request

fix issue #112

What changed?

I have added a function to load the textdomain and make the translations working

Did you fix any specific issues?

fix issue #112

CERTIFICATION

By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.

[sebastienserre]

@namithj , I didn't find how to add you as reviewer.

[namithj]

Can you move this to the controller class

[namithj]

@asirota should we actually do this. The languages loading is automatic in Wordpress (not sure from which version), this can serve for older versions though, no harm in adding it. Only problem I see is, people might not fully follow the naming conventions required for autoloading.

[sebastienserre]

done @namithj

[asirota]

Well done. Thank you @sebastienserre for making AspireUpdate load translations that we get submitted. Eventually we will use something like glotpress but for now they will be part of the plugin.

[afragen]

@asirota should we actually do this. The languages loading is automatic in Wordpress (not sure from which version), this can serve for older versions though, no harm in adding it. Only problem I see is, people might not fully follow the naming conventions required for autoloading.

Since WP 4.6 it should be unnecessary to use load_plugin_textdomain()

[asirota]

Since WP 4.6 it should be unnecessary to use load_plugin_textdomain()

Is there a better approach we can use?

[namithj]

It should have been unnecessary, but apparently the translations are not loading without it. This was the original prescribed method so nothing wrong in having it there.

[afragen]

So yes, as of WP 4.6 translation files that are stored in the WP_LANG_DIR/plugins or WP_LANG_DIR/themes. Files stored within the plugin's languages folder I believe it's still required to use load_plugin_textdomain() which should be loaded in the init hook.

There are a few methods of decoupled language packs that load the translation files into the WP_LANG_DIR/plugins and therefore are automatically loaded.

https://github.com/wearerequired/traduttore
https://github.com/afragen/translations-updater

I think both of the above will update languages packs separately from the plugin and load the packs into the WP_LANG_DIR/plugins folder.

[sebastienserre]

On my side, the French translation was correctly loaded in the plugin list (plugin description) without the load_plugin_textdomain().
Only plugin settings were not correctly loaded which is maybe the sign of a bug inside the plugin.