Settings Saved Notice #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings Saved Notice
asirota
approved these changes
Nov 12, 2024
|
Merging the two _notice functions. |
Combine admin notice functions
|
@costdev PR Updated |
|
Unit tests failed. Please review |
Looks like Its got to do with w.org. https://wordpress.org/latest.tar.gz is giving 502 error. |
|
Yeah it's most likely linked to the 502s. There's nothing in the PR that should affect the existing tests. Nevertheless, I ran the test suite locally for Single Site and Multisite on PHP 7.4 and PHP 8.2 and can confirm that all tests are passing. |
What are the 502s? |
|
W.org was down for 4-6 hours today due to some bad server config! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings Saved Notice
Pull Request
What changed?
Settings Saved Notice
Why did it change?
Add a Settings Saved Notice for clarity
Did you fix any specific issues?
#155
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.