Add eligibility criteria to datasets.toml #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J535D165
commented
Dec 2, 2024
J535D165
commented
Dec 2, 2024
EmilyWes
suggested changes
Dec 3, 2024
There was a problem hiding this comment.
I think all criteria should start and end with a quote, resulting in triple quotes in the file. This to make clear they are blocked quotes from in the papers.
Currently this is not yet the case for: Appenzeller-Herzog, Bos, Brouwer, Donners, Leenaars_2020, Moran, Oud, Sep and Wassenaar.
2 criteria are missing (their names changed over time):
van_de_Schoot and (van_der_)Valk
|
Good catch on Valk and Schoot dataset. Will open another PR. |
J535D165
commented
Dec 4, 2024
J535D165
commented
Dec 4, 2024
|
Thanks for the reviews. Helped. @EmilyWes, I didn't incorporate your first suggestion because of the TOML specification https://toml.io/en/v1.0.0#string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Rensvandeschoot @EmilyWes extracted the eligibility criteria from the supplementing publication for each synergy dataset. This PR adds the quoted sections to the TOML metadata for the SYNERGY datasets.
These sections are especially relevant to machine learning applications based on chatbot/LLM technology. For more use cases, please take a look at issue #94.
In another PR, I will update the release pipeline and add the criteria to the released dataset (however, feel free to use it from the TOML file already).