Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use Condition in hasValues of row assertions #110

Open
soezen opened this issue Oct 20, 2020 · 3 comments · May be fixed by #109
Open

Possibility to use Condition in hasValues of row assertions #110

soezen opened this issue Oct 20, 2020 · 3 comments · May be fixed by #109
Milestone

Comments

@soezen
Copy link
Contributor

soezen commented Oct 20, 2020

I would like to include condition objects when I call the hasValue method of a row assertion

softAssertions.assertThat(changes)
                .changeOnTableWithPks(tableName, primaryKeyValue)
                .isCreation()
                .rowAtEndPoint()
                .hasValues(1, 'Test', new HamcrestCondition<>(Matchers.greaterThan(2)));
@soezen soezen linked a pull request Oct 20, 2020 that will close this issue
@VanRoy
Copy link
Member

VanRoy commented Nov 1, 2020

Hi @soezen , thanks for your report and your PR. It's a good idea. However, I think it would be better to implement this feature with different method name and implement some tests.
I can handle this, and I also plan to support Consumer in addition to Condition for many assertj-db methods.
I'll let you know quickly.

@soezen
Copy link
Contributor Author

soezen commented Nov 2, 2020 via email

@VanRoy
Copy link
Member

VanRoy commented Feb 23, 2021

Hi @soezen , a first implementation of hasValuesSatisfying with Condition is pushed on main.
It wil be available soon in the next release.
Sorry for the delay.

@VanRoy VanRoy added this to the 2.1.0 milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants