Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS credentials override via environment variables #13

Open
zstumgoren opened this issue Mar 17, 2017 · 2 comments
Open

Support AWS credentials override via environment variables #13

zstumgoren opened this issue Mar 17, 2017 · 2 comments
Milestone

Comments

@zstumgoren
Copy link
Contributor

It's quite possible that multiple collaborators on a data project will have multiple AWS profiles, and that the aws profile name for the shared resource do not match ~/.aws/credentials. For example, one user could have the shared creds under "default", while another user has them under "work".

While members could sidestep this issue by duplicating the credentials under a new, common name, it would be nice to support profile customizations by user.

We should update the data push and pull commands so that precedence is given to environment variables, if present when invoking aws s3 sync.

/cc @myersjustinc

@zstumgoren zstumgoren added this to the 0.3 milestone Mar 17, 2017
@myersjustinc
Copy link

Here's the list of environment variables the AWS CLI supports.

@zstumgoren
Copy link
Contributor Author

@myersjustinc Thanks for the link. The plugin uses the --profile flag by default, so we'll need to build in a mechanism at the datakit layer to check for the presence of environmental variable(s) and give those precedence. Open to suggestions on whether to check for the AWS_DEFAULT_PROFILE env var or the combo of AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY. Leaning toward the former since it simplifies implementation and reenforces usage of the ~/.aws hidden directory. Could also support both, though not sure if absence of the region env var will cause problems in the latter scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants