Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conductor: parse oracle data from extended_commit_info and send to rollup if it exists #1818

Open
noot opened this issue Nov 18, 2024 · 0 comments
Assignees
Labels
conductor pertaining to the astria-conductor crate enhancement New feature or request

Comments

@noot
Copy link
Collaborator

noot commented Nov 18, 2024

once the extended commit info is inside SequencerBlock and written to DA, conductor can access it and send the data inside of it to rollups.

conductor does not need to do additional validation on the extended commit info, as it will only be finalized by the sequencer if valid.

the RollupData enum should be updated to contain an OracleData variant, which can be a vec of prices such as:

message Price {
  CurrencyPair currency_pair = 1;
  QuotePrice price = 2;
  uint64 decimals = 3;
}

conductor then needs to parse the extended commit info into a OracleData by parsing the prices and taking the median (logic which is already implemented in sequencer) and then pass this as a RollupData to the rollup.

┆Issue Number: ENG-1017

@noot noot added enhancement New feature or request conductor pertaining to the astria-conductor crate labels Nov 18, 2024
@noot noot self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conductor pertaining to the astria-conductor crate enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant