Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor models into different files #219

Open
jasonmcewen opened this issue Jun 20, 2022 · 2 comments
Open

Refactor models into different files #219

jasonmcewen opened this issue Jun 20, 2022 · 2 comments
Assignees
Labels
infrastructure Code base change, no feature add

Comments

@jasonmcewen
Copy link
Contributor

At present all models are implemented in model.py. This file is currently also ~2000 lines long. Let's factor out the different models into separate files, keeping the abstract class in, say, model.py. Then we can more easily add new models.

@mmdocherty mmdocherty self-assigned this Jul 27, 2022
@mmdocherty mmdocherty added the infrastructure Code base change, no feature add label Jul 27, 2022
@mmdocherty mmdocherty added this to the Release v1.1.2 milestone Jul 27, 2022
@jasonmcewen
Copy link
Contributor Author

Now we have flow support, we should put the abstract class in one file, then the legacy models in another, and the flow models in another.

@jasonmcewen
Copy link
Contributor Author

We discussed this. The plan is to have the abstract class in model_abstract.py and then to have model.py for the flows and model_legacy.pyx for the legacy ML methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Code base change, no feature add
Projects
Status: Ice Box
Development

No branches or pull requests

2 participants