Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github custom actions #1689

Open
1 of 4 tasks
johnhoran opened this issue Jul 25, 2024 · 0 comments
Open
1 of 4 tasks

Github custom actions #1689

johnhoran opened this issue Jul 25, 2024 · 0 comments

Comments

@johnhoran
Copy link

johnhoran commented Jul 25, 2024

✍️ Is your feature request related to a problem? Please describe.
A recent update to astro cli (v1.28.0) broke our astro deployments. We were deploying in dag-deploy mode through github actions, and we noticed the issue when somebody tried to deploy an updated dag but their changes didn't show up.

Our frustration here is, due to how astro-cli is installed, we either have to chose to pin the version of astro-cli, or allow astro to update it without us doing any validation in advance. Neither solution is great, if we pin we run the risk of having such an old version that eventually its out of support, if we let it float we run the risk of breakage in the future.

🧩 Describe the solution you'd like
Ideally we would pin the astro-cli version and get dependabot to create PRs for new versions when they are available. This is how we approach both the astronomer version and the dependencies we install into it via pip. This could be accomplished by using a github-action to install the astro-cli instead of some script fed from curl. This could work similiar to https://github.com/google-github-actions/setup-gcloud, but ideally it would be included in the astro-cli repo. This would mean that we would install astro-cli in github actions using something like

    - uses: 'astronomer/[email protected]'

and then dependabot would ensure we're running a recent version.

🤔 Describe alternatives you've considered

Is your feature request specific to a particular Astronomer Platform?

  • Astro
  • Software
  • None/Unknown

💡 Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant