Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Param docstring for load_pandas_dataframe_to_table: "Local or remote filepath" implies incorrect type #2162

Open
thomkav opened this issue May 21, 2024 · 0 comments

Comments

@thomkav
Copy link

thomkav commented May 21, 2024

Hey Astro,

Loving the software so far. This is a documentation nit, no bug here. The param docstring for all load_pandas_dataframe_to_table functions implies that source_dataframe is Local or remote filepath. The typing and actual implementation indicates a Dataframe is expected. I happened to be testing postgres, but I checked that documentation for other connection types under databases.base have the same error.

:param source_dataframe: Local or remote filepath

@thomkav thomkav changed the title Nit: Local or remote filepath implies incorrect type Nit: Param docstring for load_pandas_dataframe_to_table: "Local or remote filepath" implies incorrect type May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant