Added support for temporary table upload in alma

[andamian]

Solution for #3030

Also cleaned up some of the alma remote tests to make them a little bit faster.

[pep8speaks]

Hello @andamian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-12 00:06:29 UTC

[keflavich]

Looks like a nice addition, just needs a little clearer documentation - can you provide an example upload table in the narrative docs?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.37%. Comparing base (92adbe8) to head (f41f708).
Report is 160 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3118      +/-   ##
==========================================
- Coverage   67.39%   67.37%   -0.02%     
==========================================
  Files         233      233              
  Lines       18421    18410      -11     
==========================================
- Hits        12415    12404      -11     
  Misses       6006     6006              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andamian]

Not sure what the problem is now. There's 100% patch coverage.

[bsipocz]

Not sure what the problem is now. There's 100% patch coverage.

Ignore that, coverage number doesn't take remote tests into account.

[bsipocz]

Overall looks good to me. I'll leave the actual approval and merge to Adam though.

One minor comment, that I see a bunch of test failures in the docs, all of those are present on main, too but it would be nice to eventually clean them up.

[andamian]

Can this be merged or do I need to try to fix the failing check (which I have no idea why is failing)? Thanks

[bsipocz]

No, coverage is a red herring (it doesn't take into account the remote coverage and anyways likes to act up).

I was waiting to give Adam a chance to chime in, but I suppose it's time to get this merged. Thanks!

[keflavich]

Yep, sorry, I was happy with this.

[andamian]

Thank you both.