Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2949: nasa_exoplanet_archive transit duration unit fix #3137

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

rickynilsson
Copy link
Contributor

@rickynilsson rickynilsson commented Nov 22, 2024

pl_trandur unit updated from day(s) to hour(s) in TAP, and hour added to dictionary mapping unit strings to astropy units in core.py

fixes #2949

@rickynilsson
Copy link
Contributor Author

Is a changelog entry really necessary for this fix @bsipocz? Not sure what to do about the Python 3.13 build issue.

@bsipocz
Copy link
Member

bsipocz commented Nov 25, 2024

I'll rebase to get rid of the unintended changes you pushed for the submodule. That should fix the 3.13 build issues, too.
And indeed, it's good to have a changelog here as this was a user facing fix that got reported by a user.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base (ce16157) to head (50867f6).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3137   +/-   ##
=======================================
  Coverage   67.53%   67.53%           
=======================================
  Files         233      233           
  Lines       18487    18487           
=======================================
  Hits        12486    12486           
  Misses       6001     6001           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bsipocz bsipocz merged commit 3a207b2 into astropy:main Nov 25, 2024
11 checks passed
@bsipocz
Copy link
Member

bsipocz commented Nov 25, 2024

Thanks @rickynilsson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in units for NASA Exoplanet Archive results
2 participants