Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.11 CI test failure #227

Closed
kecnry opened this issue Nov 11, 2024 · 2 comments
Closed

python 3.11 CI test failure #227

kecnry opened this issue Nov 11, 2024 · 2 comments
Labels

Comments

@kecnry
Copy link
Member

kecnry commented Nov 11, 2024

specreduce/tests/test_synth_data.py::test_make_2d_arc_pass_wcs is now failing with:

astropy.units.core.UnitConversionError: Can only apply 'greater' function to dimensionless quantities when other argument is not a quantity (unless the latter is all zero/infinity/nan).

during a call to specutils

../../specreduce/utils/synth_data.py:290: in make_2d_arc_image
    linelist = load_pypeit_calibration_lines(linelists, wave_air=wave_air)
../../specreduce/calibration_data.py:288: in load_pypeit_calibration_lines
    linelist['wavelength'] = vac_to_air(linelist['wavelength'])
../../.tox/py311-test-alldeps-cov/lib/python3.11/site-packages/specutils/utils/wcs_utils.py:148: in vac_to_air
    refr = refraction_index(wavelength, method=method, co2=co2)
../../.tox/py311-test-alldeps-cov/lib/python3.11/site-packages/specutils/utils/wcs_utils.py:103: in refraction_index
    if method != 'Griesen2006' and wavelength.min() < 200 * u.nm:
@pllim
Copy link
Member

pllim commented Nov 11, 2024

Is this linelist['wavelength'] not Quantity?

@pllim pllim added the bug label Nov 11, 2024
hpparvi added a commit to hpparvi/specreduce that referenced this issue Nov 15, 2024
… a QTable before calling `specutils.utils.wcs_utils.vac_to_air`.
@hpparvi
Copy link
Contributor

hpparvi commented Nov 15, 2024

This is now fixed in PR #231.

@pllim pllim closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants