Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertions are no-ops in test programs when using CMake "release" build configurations #3

Open
Jenny-fa opened this issue Sep 9, 2015 · 0 comments

Comments

@Jenny-fa
Copy link
Collaborator

Jenny-fa commented Sep 9, 2015

Several test programs in Origin make use of the C library's assert macro, which is problematic because three of CMake's predefined build configurations ("Release", "MinSizeRel", and "RelWithDebInfo") use the compiler flag -DNDEBUG, which causes assert to become a no-op. Unless this is the intended behavior, test programs should use an alternate assert macro/function.

Note: The "Debug" configuration has no such problem, as does building Origin without explicitly specifying a configuration (the default option).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant