Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for kernel versions >= 5.0.14 are now also required for 4.x branch #12

Open
fonic opened this issue Jun 27, 2019 · 6 comments
Open

Comments

@fonic
Copy link

fonic commented Jun 27, 2019

It seems the changes introduced in kernel 5.0.14 were recently backported to the 4.x branch. I encountered compiling problems after upgrading to kernel 4.19.52. With the changes implemented by #11, the driver compiles and works fine again.

I simple changed:
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 0, 14))
to
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 0, 14)) || (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 19, 52))

@svfed
Copy link

svfed commented Sep 4, 2019

The same with 4.15.0 starting with 4.15.0-60.

@aayushbhan
Copy link

@svfed what did you change to make it work for 4.15.0-60 ?

@svfed
Copy link

svfed commented Oct 8, 2019

Since the change of power usage count may go to any kernel version, I have chosen not to add version check as @fonic, but rather defined in rts51x.h:
#define OLD_KERNEL_PM_CNT_UPDATED 1
and right after that
#if ((LINUX_VERSION_CODE >= KERNEL_VERSION(5, 0, 14)) || OLD_KERNEL_PM_CNT_UPDATED)
and the same in all source files that require it (5 places in rts51x.c, for example)

@aayushbhan
Copy link

Ok thanks. I'll check if it works for me.

@vladki77
Copy link

I confirm that this change is needed for Debian stretch kernels too:
Linux 4.9.0-11-amd64 #1 SMP Debian 4.9.189-3+deb9u1 (2019-09-20) x86_64 GNU/Linux

@michael-xiii
Copy link

It helps for Dell Inspiron 3180

Linux small-note 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Changes appear somewhere after the 4.15.0-58 but before 4.15.0-65,, hard to tell

Also - I don't see the freezes now, they were the headache on 4.15.0-58 #15

But need some time for being sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants