Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug : navigation tab is not working properly #1008

Closed
aialok opened this issue May 30, 2024 · 11 comments · Fixed by #1046
Closed

🐛 bug : navigation tab is not working properly #1008

aialok opened this issue May 30, 2024 · 11 comments · Fixed by #1046
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released

Comments

@aialok
Copy link

aialok commented May 30, 2024

Description

  • Navigation tab between schema and configuration is not working as expected.

Expected Result

  • It should navigate properly between the schema tab and configuration tab.
Screencast.from.2024-05-30.17-23-42.webm

Actual Result

Screencast.from.2024-05-30.17-28-34.webm

Steps to Reproduce

  1. Go to the AsyncAPI website homepage.
  2. Click on the configuration tab.
  3. Click on the schema tab.
  4. Try to navigate back to the configuration tab.

Troubleshooting

  • I found there is issue in tabIndex. Basically in one of if statement we are checking tabIndex but tabIndex is value can equal to zero and schema tab tabIndex is zero so when navigating back to schema tab from configuration tab. If statement is not working and hence navigation is not working.
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@aialok
Copy link
Author

aialok commented May 30, 2024

I would love to work on this issue : )

@derberg
Copy link
Member

derberg commented Jun 20, 2024

@aialok please go ahead and open a PR

@AnshulKahar2729
Copy link

Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?

@AceTheCreator
Copy link
Member

Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?

@AnshulKahar2729 do you mean contributors guideline?

@AnshulKahar2729
Copy link

Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?

@AnshulKahar2729 do you mean contributors guideline?

Yes

@AceTheCreator
Copy link
Member

Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?

@AnshulKahar2729 do you mean contributors guideline?

Yes

These are the ones I recommend.

@AceTheCreator
Copy link
Member

Let me know if you need any help 🙏🏾

@AceTheCreator AceTheCreator added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Sep 30, 2024
@ajaykumar-br
Copy link

ajaykumar-br commented Oct 4, 2024

@AceTheCreator This issue still persists right, can I pick it up?

@AceTheCreator
Copy link
Member

@AceTheCreator This issue still persists right, can I pick it up?

Someone opened a PR for it already, sadly. Feel free to pick other existing issues.

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released
Projects
None yet
6 participants