Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversed pub/sub action render? #815

Closed
Tracked by #733
skonik opened this issue Oct 12, 2023 · 5 comments
Closed
Tracked by #733

Reversed pub/sub action render? #815

skonik opened this issue Oct 12, 2023 · 5 comments

Comments

@skonik
Copy link

skonik commented Oct 12, 2023

Description

It seems that subscribe now renders as pub action.

Screenshot 2023-10-12 at 13 39 51

Expected result

subscribe action renders as sub.

Actual result

subscribe action renders as pub.

Steps to reproduce

Open https://asyncapi.github.io/asyncapi-react/ and scroll down to first subscribe definition in asyncapi file.

Troubleshooting

@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Oct 25, 2023

yeah, I think you're right, not sure though what is wrong as in the code we did not do the flip, but we did start using new parser that might do the flip

@ly29
Copy link

ly29 commented Nov 1, 2023

I think long term I would made sense to have 2.x and 3.x as separate thing since theese bugs keeps occuring

@fmvilas
Copy link
Member

fmvilas commented Nov 3, 2023

This bug has nothing to do with v2 or v3 but with the way we're using the parser. It's just something normal that during the migration to the new parser something got wrong. It shouldn't happen again in the future or it's very unlikely.

@derberg
Copy link
Member

derberg commented Nov 16, 2023

closing as solved with #795

@derberg derberg closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants