From bd90964e111e8a51a4a7b3f58496c07e594c985f Mon Sep 17 00:00:00 2001 From: derberg Date: Mon, 24 Jun 2024 17:27:36 +0200 Subject: [PATCH] fix: remove core needed prior react 18 to fix release of webcomponent and playground --- .../workflows/release-wc-and-playground.yml | 18 ++++++++++++++++++ playground/app/page.tsx | 1 - playground/components/CodeEditorComponent.tsx | 1 - playground/components/SplitWrapper.tsx | 1 - web-component/package.json | 4 ++-- web-component/webpack.config.js | 2 +- 6 files changed, 21 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release-wc-and-playground.yml b/.github/workflows/release-wc-and-playground.yml index 9e7270e3b..65d50a215 100644 --- a/.github/workflows/release-wc-and-playground.yml +++ b/.github/workflows/release-wc-and-playground.yml @@ -55,6 +55,15 @@ jobs: package: ./web-component/package.json access: public tag: github.event.release.target_commitish + - if: failure() # Only, on failure, send a message on the 94_bot-failing-ci slack channel + name: Report workflow run status to Slack + uses: 8398a7/action-slack@v3 + with: + status: ${{ job.status }} + fields: repo,action,workflow + text: 'Release of web component for AsyncAPI React failed' + env: + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CI_FAIL_NOTIFY }} playground: name: Release Playground @@ -89,3 +98,12 @@ jobs: folder: playground/out git-config-name: asyncapi-bot git-config-email: info@asyncapi.io + - if: failure() # Only, on failure, send a message on the 94_bot-failing-ci slack channel + name: Report workflow run status to Slack + uses: 8398a7/action-slack@v3 + with: + status: ${{ job.status }} + fields: repo,action,workflow + text: 'Release of playground for AsyncAPI React failed' + env: + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CI_FAIL_NOTIFY }} \ No newline at end of file diff --git a/playground/app/page.tsx b/playground/app/page.tsx index a3a9ba62b..66c128f42 100644 --- a/playground/app/page.tsx +++ b/playground/app/page.tsx @@ -93,7 +93,6 @@ class Playground extends Component { - {/* @ts-expect-error remove when library and web-component is upgraded to React v18 */} diff --git a/playground/components/CodeEditorComponent.tsx b/playground/components/CodeEditorComponent.tsx index d185e441b..6d2f90b76 100644 --- a/playground/components/CodeEditorComponent.tsx +++ b/playground/components/CodeEditorComponent.tsx @@ -33,7 +33,6 @@ class CodeEditorComponent extends Component { return ( - {/* @ts-expect-error remove when library and web-component is upgraded to React v18 */} ( <> - {/* @ts-expect-error upgrade React to v18 */}