Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removes a redundant return statement #804

Closed
wants to merge 2 commits into from

Conversation

syedzubeen
Copy link
Contributor

Description

Changes proposed in this pull request:

Removed a redundant return statement

Related issue(s)
Fixes #783

@derberg
Copy link
Member

derberg commented Oct 4, 2023

@syedzubeen Thanks for the PR. When you contribute to any project, especially open source, you should open a PR only once you are familiarized with contributing guide like https://github.com/asyncapi/asyncapi-react/blob/master/CONTRIBUTING.md

  • please adjust your PR title:
    • use imperative mood in PR title
    • use proper conventional commits prefix (you have a bot comment with details - in your case it is refactor

@syedzubeen syedzubeen changed the title Removed a redundant return statement refactor: removes a redundant return statement Oct 4, 2023
@syedzubeen
Copy link
Contributor Author

Done !

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg
Copy link
Member

derberg commented Oct 7, 2023

test fails for the same reason as described in #807 (review)

@derberg
Copy link
Member

derberg commented Dec 18, 2023

closing as not clear how to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove this redundant jump.
2 participants