From 2c5b6d17b8f7beacb9c1225ae65072bb721035c3 Mon Sep 17 00:00:00 2001
From: AayushSaini101 <kumaraayush9810@gmail.com>
Date: Sat, 4 Jan 2025 15:23:17 +0530
Subject: [PATCH] Add test cases for more commands

---
 src/core/models/SpecificationFile.ts | 10 +++++-----
 test/integration/convert.test.ts     |  9 +++++++++
 test/integration/optimize.test.ts    |  9 +++++++++
 3 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/src/core/models/SpecificationFile.ts b/src/core/models/SpecificationFile.ts
index d43045d8ec1..41a4c422a7d 100644
--- a/src/core/models/SpecificationFile.ts
+++ b/src/core/models/SpecificationFile.ts
@@ -112,12 +112,12 @@ export class Specification {
         } catch (error) {
           throw new Error(`Invalid proxy URL: ${proxyUrl}`);
         }
-      }
-
-      response = await fetch(targetUrl);
-      if (!response.ok) {
+      } else {
+        response = await fetch(targetUrl);
+        if (!response.ok) {
         //   console.log(response+" sdf")
-        throw new ErrorLoadingSpec('url', targetUrl);
+          throw new ErrorLoadingSpec('url', targetUrl);
+        }
       }
     } catch (error) {
       console.log(error);
diff --git a/test/integration/convert.test.ts b/test/integration/convert.test.ts
index ec655f778ac..e3cf5012bd0 100644
--- a/test/integration/convert.test.ts
+++ b/test/integration/convert.test.ts
@@ -58,6 +58,15 @@ describe('convert', () => {
         expect(ctx.stderr).to.equal('');
         done();
       });
+    test
+      .stderr()
+      .stdout()
+      .command(['convert', 'http://localhost:8080/dummySpec.yml --proxyHost=host --proxyPort=8080'])
+      .it('works when url is passed with proxyHost and proxyPort with invalid host ', (ctx, done) => {
+        expect(ctx.stdout).to.contain('');
+        expect(ctx.stderr).to.equal('error loading AsyncAPI document from url: Failed to download http://localhost:8080/dummySpec.yml --proxyHost=host --proxyPort=8080.\n');
+        done();
+      });
   });
 
   describe('with no arguments', () => {
diff --git a/test/integration/optimize.test.ts b/test/integration/optimize.test.ts
index 1f921e11669..3d8a1b3820f 100644
--- a/test/integration/optimize.test.ts
+++ b/test/integration/optimize.test.ts
@@ -58,6 +58,15 @@ describe('optimize', () => {
         expect(ctx.stderr).to.equal('');
         done();
       });
+    test
+      .stderr()
+      .stdout()
+      .command(['optimize', 'http://localhost:8080/dummySpec.yml --proxyHost=host --proxyPort=8080'])
+      .it('works when url is passed with proxyHost and proxyPort with invalid host ', (ctx, done) => {
+        expect(ctx.stdout).to.contain('');
+        expect(ctx.stderr).to.equal('error loading AsyncAPI document from url: Failed to download http://localhost:8080/dummySpec.yml --proxyHost=host --proxyPort=8080.\n');
+        done();
+      });
   });
 
   describe('with no arguments', () => {