Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added the start command short description #1536

Closed
wants to merge 15 commits into from

Conversation

ItshMoh
Copy link

@ItshMoh ItshMoh commented Sep 30, 2024

start_command
Added the short description for start command.
Description

Related issue(s)
#1534

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ItshMoh
Copy link
Author

ItshMoh commented Sep 30, 2024

hey @AayushSaini101 can you review the changes?

@@ -536,8 +536,11 @@
}
},
"node_modules/@asyncapi/minimaltemplate": {
"resolved": "test/fixtures/minimaltemplate",
"link": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ItshMoh Why changes are needed in package-lock.json?

@AayushSaini101
Copy link
Collaborator

@ItshMoh You are deleting the package-lock.json don't make any changes in this thanks

Copy link

sonarqubecloud bot commented Oct 2, 2024

@ItshMoh
Copy link
Author

ItshMoh commented Oct 2, 2024

@ItshMoh You are deleting the package-lock.json don't make any changes in this thanks

because on commitiing the package-lock.json there was merge conflict, so i thought that it will be better of to delete package-lock.json, should i delete it ?
cc @AayushSaini101

@AayushSaini101
Copy link
Collaborator

@ItshMoh can you merge the latest master in this branch ?

@Shurtu-gal
Copy link
Collaborator

/update

@AayushSaini101
Copy link
Collaborator

LGTM

AayushSaini101
AayushSaini101 previously approved these changes Jan 9, 2025
@AayushSaini101
Copy link
Collaborator

@ItshMoh There are some conflicts please resolve

root and others added 11 commits January 9, 2025 17:22
* New Github action added for cli

* Added new files in the github-action

* removed monorepo style for github action

* Updated github action with Dockerfile changes

* added command to pack cli for linux, docker build command

* added test-workflow for github-action

* chore: fix docker context

* chore: change docker context

* fix: dockerfile

* changed dockerfile

* fix: dockerfile

* Converted Dockerfile into multi stages

* added github-action folder

* added assets folder to github action image

* deleted act file script

* removed asyncapi.yaml file from .gitignore

* corrected output file for workflow

* updated Dockerfile

* added bundle file

* changed bundle files

* Updated README

* updated output bundle directory

---------

Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: Ashish Padhy <[email protected]>
* feat: update oclif to v4

* chore: removed unused dependencies

* Update myhook.ts
Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 8ee14c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@ItshMoh ItshMoh closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants