-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added the start command short description #1536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
hey @AayushSaini101 can you review the changes? |
package-lock.json
Outdated
@@ -536,8 +536,11 @@ | |||
} | |||
}, | |||
"node_modules/@asyncapi/minimaltemplate": { | |||
"resolved": "test/fixtures/minimaltemplate", | |||
"link": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ItshMoh Why changes are needed in package-lock.json?
@ItshMoh You are deleting the package-lock.json don't make any changes in this thanks |
Quality Gate passedIssues Measures |
because on commitiing the package-lock.json there was merge conflict, so i thought that it will be better of to delete package-lock.json, should i delete it ? |
@ItshMoh can you merge the latest master in this branch ? |
/update |
LGTM |
@ItshMoh There are some conflicts please resolve |
…#1527) Co-authored-by: Ashish Padhy <[email protected]>%0ACo-authored-by: asyncapi-bot <[email protected]>
* New Github action added for cli * Added new files in the github-action * removed monorepo style for github action * Updated github action with Dockerfile changes * added command to pack cli for linux, docker build command * added test-workflow for github-action * chore: fix docker context * chore: change docker context * fix: dockerfile * changed dockerfile * fix: dockerfile * Converted Dockerfile into multi stages * added github-action folder * added assets folder to github action image * deleted act file script * removed asyncapi.yaml file from .gitignore * corrected output file for workflow * updated Dockerfile * added bundle file * changed bundle files * Updated README * updated output bundle directory --------- Co-authored-by: asyncapi-bot <[email protected]> Co-authored-by: Ashish Padhy <[email protected]>
* feat: update oclif to v4 * chore: removed unused dependencies * Update myhook.ts
…1534) (asyncapi#1537) Co-authored-by: Ashish Padhy <[email protected]>
|
Quality Gate failedFailed conditions |
Added the short description for start command.
Description
Related issue(s)
#1534