-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added the progress bar for generate command. #1552
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR @ItshMoh Please include this in all the commands of the CLI and fix Quality Gate |
Sure @AayushSaini101 |
@ItshMoh how is the progress being calculated ? |
Quality Gate failedFailed conditions |
Hey @Shurtu-gal I have updated the logic. So in the new logic here i have divided it into 3 steps. The first step is Initializing generator , Generating Files and the last for completion of generation. After the step the progress bar increases. |
What I am not understanding is how is a progress bar different from the current spinner we have if we don't have any way to measure the current progress in generation. Note: @Souvikns has also proposed removing the spinner altogether https://github.com/amplication |
Hey @Shurtu-gal Should i remove the spinner alltogether ? |
@Souvikns do require this feature to be there as we don't have any set time or some kind of progress parameter I guess this would rather just be a aesthetic thing. |
Description
Added a progress bar for the generate command in the cli.
https://www.loom.com/share/72534057ea2644f997bae71fb4c79957?sid=7e05ac94-c362-4860-9dfb-333ff07bfff4
Related issue(s)
fixes #1410