Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the progress bar for generate command. #1552

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ItshMoh
Copy link

@ItshMoh ItshMoh commented Oct 20, 2024

Description
Added a progress bar for the generate command in the cli.

https://www.loom.com/share/72534057ea2644f997bae71fb4c79957?sid=7e05ac94-c362-4860-9dfb-333ff07bfff4

Related issue(s)
fixes #1410

@AayushSaini101
Copy link
Contributor

Thanks for the PR @ItshMoh Please include this in all the commands of the CLI and fix Quality Gate

@ItshMoh
Copy link
Author

ItshMoh commented Oct 21, 2024

Thanks for the PR @ItshMoh Please include this in all the commands of the CLI and fix Quality Gate

Sure @AayushSaini101

@Shurtu-gal
Copy link
Collaborator

@ItshMoh how is the progress being calculated ?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
29.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ItshMoh
Copy link
Author

ItshMoh commented Oct 21, 2024

@ItshMoh how is the progress being calculated ?

Hey @Shurtu-gal I have updated the logic. So in the new logic here i have divided it into 3 steps. The first step is Initializing generator , Generating Files and the last for completion of generation. After the step the progress bar increases.
Do you have anything extra that i can add?

@Shurtu-gal
Copy link
Collaborator

Hey @Shurtu-gal I have updated the logic. So in the new logic here i have divided it into 3 steps. The first step is Initializing generator , Generating Files and the last for completion of generation. After the step the progress bar increases. Do you have anything extra that i can add?

What I am not understanding is how is a progress bar different from the current spinner we have if we don't have any way to measure the current progress in generation.

Note: @Souvikns has also proposed removing the spinner altogether https://github.com/amplication

@ItshMoh
Copy link
Author

ItshMoh commented Oct 22, 2024

What I am not understanding is how is a progress bar different from the current spinner we have if we don't have any way to measure the current progress in generation.

Note: @Souvikns has also proposed removing the spinner altogether https://github.com/amplication

Hey @Shurtu-gal Should i remove the spinner alltogether ?

@Shurtu-gal
Copy link
Collaborator

@Souvikns do require this feature to be there as we don't have any set time or some kind of progress parameter I guess this would rather just be a aesthetic thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding a progress bar for CLI Commands to show the progress status
3 participants