-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to Consider the Case Senstive feature in CLI while creating new file. #790
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
I think this is where the issues is Line 145 in 2cc2697
https://stackoverflow.com/questions/27367261/check-if-file-exists-case-sensitive |
Thanks, @Souvikns Yes, here is the issue. that need to be changed, but, If we write the logic to create a new file after comparing the case as well, we cannot because OS doesn't allow to creation of two separate files with different cases. |
Yeah, could we change the |
@Souvikns We can do this when the user tries to create a file of the same name but different case it should get a message that a particular file is present with a different case. Please change the name. What's your thought? |
🤔 actually the less warning from CLI the better the user experience, it would be better to handle this issue internally, and in our case, we can't really save two same file names with lower and uppercase because of how the filesystem works in nodejs. In my opinion, the error message we have right now works fine, and no need to change anything. |
wasn't it solved? |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
I agree with this approach 👍 @Souvikns Shouldn't we convert the input to lowercase as you proposed here? |
/gfi ts |
Agreed that the less warnings the better user experience but since many doesn't/ will not know the OS case-insensitivity they will get confused as to why different name is not working and if Tutorial.txt already exist. Thus, will try TUTORIAL.txt or something and fail. Maybe, we can give a better CLI response like " Error: A file named "tutorial.txt" already exists in the directory. Your current file system is case-insensitive, so "Tutorial.txt" would be treated as the same file name. Please choose a different name for your new file or delete/rename the existing file." |
I am willing to change the CLI response if this idea sounds ok |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Reason/Context
Please try answering a few of those questions
Why do we need this improvement?
CLI should be case-sensitive while creating the file, currently, it is treating tutorial.yml and Tutorial.yml the same and enables to creation of files.
How will this change help?
It will always be optimal to consider the case-sensitive feature in the CLI
Description
Please try answering a few of those questions
The text was updated successfully, but these errors were encountered: