From 5f742e337db6be7dfdb220dee97489ef82589862 Mon Sep 17 00:00:00 2001 From: Sahil-Shadwal Date: Fri, 20 Dec 2024 20:51:11 +0530 Subject: [PATCH 1/5] fix .github/workflows/test-action.yml to bump up to latest version --- .github/workflows/test-action.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/test-action.yml b/.github/workflows/test-action.yml index 49960223be7..99b31167015 100644 --- a/.github/workflows/test-action.yml +++ b/.github/workflows/test-action.yml @@ -11,14 +11,14 @@ jobs: - if: > !github.event.pull_request.draft && !( (github.actor == 'asyncapi-bot' && ( - startsWith(github.event.pull_request.title, 'ci: update of files from global .github repo') || + startsWith(github.event.pull_request.title, 'ci: update of files from global .github repo') || startsWith(github.event.pull_request.title, 'chore(release):') )) || (github.actor == 'asyncapi-bot-eve' && ( - startsWith(github.event.pull_request.title, 'ci: update of files from global .github repo') || + startsWith(github.event.pull_request.title, 'ci: update of files from global .github repo') || startsWith(github.event.pull_request.title, 'chore(release):') )) || - (github.actor == 'allcontributors[bot]' && + (github.actor == 'allcontributors[bot]' && startsWith(github.event.pull_request.title, 'docs: add') ) ) @@ -54,7 +54,7 @@ jobs: tags: asyncapi/github-action-for-cli:${{ steps.docker_version.outputs.action_version }} outputs: type=docker,dest=/tmp/asyncapi.tar - name: Upload artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: asyncapi path: /tmp/asyncapi.tar @@ -66,7 +66,7 @@ jobs: needs: [should-workflow-run, build-docker] steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: asyncapi path: /tmp @@ -81,8 +81,8 @@ jobs: filepath: ./github-action/test/asyncapi.yml - name: Assert GitHub Action run: | - echo "Listing all files" - ls -R + echo "Listing all files" + ls -R echo "Asserting GitHub Action" if [ -f "./output/asyncapi.md" ]; then echo "Files exist" @@ -146,7 +146,7 @@ jobs: echo "Action failed" exit 1 fi - + test-custom-output: if: ${{ needs.should-workflow-run.outputs.shouldrun == 'true' }} runs-on: ubuntu-latest @@ -179,7 +179,7 @@ jobs: echo "Action failed" exit 1 fi - + test-file-not-found: if: ${{ needs.should-workflow-run.outputs.shouldrun == 'true' }} runs-on: ubuntu-latest @@ -209,7 +209,7 @@ jobs: else echo "Test Success: non_existent_file.yml threw an error as expected" fi - + test-invalid-input: if: ${{ needs.should-workflow-run.outputs.shouldrun == 'true' }} runs-on: ubuntu-latest @@ -275,7 +275,7 @@ jobs: echo "Action failed" exit 1 fi - + test-bundle: if: ${{ needs.should-workflow-run.outputs.shouldrun == 'true' }} runs-on: ubuntu-latest @@ -309,7 +309,7 @@ jobs: echo "Action failed" exit 1 fi - + test-convert: if: ${{ needs.should-workflow-run.outputs.shouldrun == 'true' }} runs-on: ubuntu-latest @@ -329,7 +329,7 @@ jobs: uses: ./ with: command: convert - filepath: github-action/test/asyncapi.yml + filepath: github-action/test/asyncapi.yml output: output/convert/asyncapi.yaml - name: Assert GitHub Action run: | From 17d8888bde4dd77b2ccb704de1d862f7c9848442 Mon Sep 17 00:00:00 2001 From: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com> Date: Sat, 21 Dec 2024 18:35:50 +0530 Subject: [PATCH 2/5] chore: bump rest of the download actions --- .github/workflows/test-action.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test-action.yml b/.github/workflows/test-action.yml index 99b31167015..3b6a1ed0038 100644 --- a/.github/workflows/test-action.yml +++ b/.github/workflows/test-action.yml @@ -98,7 +98,7 @@ jobs: needs: [should-workflow-run, build-docker] steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: asyncapi path: /tmp @@ -119,7 +119,7 @@ jobs: needs: [should-workflow-run, build-docker] steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: asyncapi path: /tmp @@ -153,7 +153,7 @@ jobs: needs: [should-workflow-run, build-docker] steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: asyncapi path: /tmp @@ -186,7 +186,7 @@ jobs: needs: [should-workflow-run, build-docker] steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: asyncapi path: /tmp @@ -216,7 +216,7 @@ jobs: needs: [should-workflow-run, build-docker] steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: asyncapi path: /tmp @@ -248,7 +248,7 @@ jobs: needs: [should-workflow-run, build-docker] steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: asyncapi path: /tmp @@ -282,7 +282,7 @@ jobs: needs: [should-workflow-run, build-docker] steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: asyncapi path: /tmp @@ -316,7 +316,7 @@ jobs: needs: [should-workflow-run, build-docker] steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: asyncapi path: /tmp From 3d18f2f5cc393515d7612fc57798276f8d4519fd Mon Sep 17 00:00:00 2001 From: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com> Date: Sat, 21 Dec 2024 18:37:39 +0530 Subject: [PATCH 3/5] chore: ignore dockerfiles in sonarcloud --- .sonarcloud.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.sonarcloud.properties b/.sonarcloud.properties index fbba2f0d869..c3855a2d181 100644 --- a/.sonarcloud.properties +++ b/.sonarcloud.properties @@ -1,4 +1,4 @@ -sonar.exclusions=test/**/*,Dockerfile +sonar.exclusions=test/**/*,Dockerfile,github-action/Dockerfile sonar.issue.ignore.multicriteria=e1,e2 # Exclude copy recursively and root user issue in Dockerfile From c4790e63c26a9d4c82829b61e85cf4b52611da30 Mon Sep 17 00:00:00 2001 From: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com> Date: Sat, 21 Dec 2024 18:38:13 +0530 Subject: [PATCH 4/5] fix: release docker workflow --- .github/workflows/release-docker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-docker.yml b/.github/workflows/release-docker.yml index ddc04fd14b1..1bfd870ceaa 100644 --- a/.github/workflows/release-docker.yml +++ b/.github/workflows/release-docker.yml @@ -19,7 +19,7 @@ jobs: - name : Checkout repository uses: actions/checkout@v4 with: - ref: tags/${{ github.event.release.tag_name }} + ref: ${{ github.event.release.tag_name }} - name: Set Up QEMU uses: docker/setup-qemu-action@v2 From 862af9e029072a32ef9b984ca7137f5f62219906 Mon Sep 17 00:00:00 2001 From: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com> Date: Sat, 21 Dec 2024 18:40:17 +0530 Subject: [PATCH 5/5] chore: add changeset --- .changeset/red-paws-ring.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/red-paws-ring.md diff --git a/.changeset/red-paws-ring.md b/.changeset/red-paws-ring.md new file mode 100644 index 00000000000..bee60532207 --- /dev/null +++ b/.changeset/red-paws-ring.md @@ -0,0 +1,5 @@ +--- +"@asyncapi/cli": patch +--- + +ci: bump artifact actions to v4