Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cognitive complexity issue #1040

Closed
derberg opened this issue Sep 28, 2023 · 2 comments · Fixed by #1047
Closed

Fix cognitive complexity issue #1040

derberg opened this issue Sep 28, 2023 · 2 comments · Fixed by #1047
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released

Comments

@derberg
Copy link
Member

derberg commented Sep 28, 2023

So generate command from https://github.com/asyncapi/generator/blob/master/lib/generator.js#L163 grew a bit and our code smell checks complain

I think the point is valid, maybe for maintainers it is not a big problem, but for contributors, for sure.

We need help from someone to figure out how best refactor that part
@derberg derberg added enhancement New feature or request good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Sep 28, 2023
@derberg derberg mentioned this issue Sep 28, 2023
Merged
@swastiksuvam55
Copy link
Contributor

Hey @derberg can you please review my PR #1047 for this issue #1040 and let me know if any more modifications or refactoring is need or not.
Thank You.

@swastiksuvam55 swastiksuvam55 mentioned this issue Oct 8, 2023
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: generate function refactored to reduce cognitive complexity swastiksuvam55/generator
3 participants
@derberg @asyncapi-bot @swastiksuvam55