-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve arborist (npm installation) to have no hacks #1102
Comments
/gfi js |
I am on it |
@AayushSaini101 thanks |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
As @akkshitgupta does not want to work in it anymore, i am going to take this over from the work left from #1115 |
@Gmin2 awesome, I closed the other PR @akkshitgupta thanks for initial contribution! |
Hey @derberg would like to work on this issue just wanted to clear one thing there's no dependency section in package.json so where should I mention the pacote dependency ? |
@ShashwatPS the structure of the codebase is changed a bit (Now its following monorepo architecture) you can add mentioned dependency in generator app package.json file. |
as @DhairyaMajmudar wrote, add dependency to apps/generator |
Is anyone working on this issue? |
Hi @derberg , I want to work on this issue , can you please assign me this issue or should i directly raise a PR ? Edit : I have fixed the issue , i have also updated index.md which is related to another issue in this repo can i solve both issues in the same PR? |
make seperate pr for seperate issues, and we dont generally assign issues, feel free to send a PR fixing the issue ! |
use this PR as inspiration, except for:
What you need to do:
pacote
dependencygenerator.js
as it is done in linked PRThe text was updated successfully, but these errors were encountered: