Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce monorepo with filters package included #1155

Closed
wants to merge 14 commits into from
Closed

feat: introduce monorepo with filters package included #1155

wants to merge 14 commits into from

Conversation

ayushnau
Copy link
Contributor

@ayushnau ayushnau commented Mar 28, 2024

Changes Added.

  1. Turborepo Added.
  2. Converted the generator repo to app, inside the turborepo.
  3. Added the required scripts of the turborepo to the root package.json file.

Related issue(s)

Resolves #1044

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ayushnau ayushnau changed the title Merge repos into single turborepo. feat:Merge repos into single turborepo. Mar 28, 2024
@ayushnau ayushnau changed the title feat:Merge repos into single turborepo. feat: Merge repos into single turborepo. Mar 28, 2024
@derberg derberg changed the title feat: Merge repos into single turborepo. feat: introduce monorepo with filters package included Mar 28, 2024
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is huge

can we introduce the change at least in 2 PRs? like first add generator-filters and then move generator to apps? cause now you just did moved all other files inside apps/generator but without checking if it makes sense, like for example all GitHub workflows

@ayushnau
Copy link
Contributor Author

ayushnau commented Apr 2, 2024

this PR is huge

can we introduce the change at least in 2 PRs? like first add generator-filters and then move generator to apps? cause now you just did moved all other files inside apps/generator but without checking if it makes sense, like for example all GitHub workflows

@derberg should i convert the generator into turborepo. on its own. first . which means adding generator to the apps directory before as that would make sense.

Also prs of merging the repos will be expected to be huge even though i add one at time in a single pr. cause i am also merging the commits.

@derberg
Copy link
Member

derberg commented Apr 2, 2024

@ayushnau yeah, I know they will be big, we just need to figure some approach maybe that can show that new files that are added are not modified or something like that, so review is smooth

but yeah, in this particular PR I know that if you split in 2 it will be big anyway, but seeing you moving GH actions workflows inside apps made me think we need to do one app at a time

@ayushnau
Copy link
Contributor Author

ayushnau commented Apr 2, 2024

@ayushnau yeah, I know they will be big, we just need to figure some approach maybe that can show that new files that are added are not modified or something like that, so review is smooth

but yeah, in this particular PR I know that if you split in 2 it will be big anyway, but seeing you moving GH actions workflows inside apps made me think we need to do one app at a time

  1. I think we can check by default in git which are only moved files
image
  1. Actually I did removed the .github file but somehow the .github file changes didnt get added in the git changes.
  2. Now I have removed the filter repo. Now it is just the generator repo.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • apps/generator/.all-contributorsrc must stay in the root
  • same sonar clound properties config - should be one for all apps
  • same eslint and editor config files right?
  • same files like codeowners or code of conduct, license, contri guide
  • same readme banner
  • also readme seems to be duplicated

@ayushnau
Copy link
Contributor Author

ayushnau commented Apr 4, 2024

  • apps/generator/.all-contributorsrc must stay in the root

    • same sonar clound properties config - should be one for all apps

    • same eslint and editor config files right?

    • same files like codeowners or code of conduct, license, contri guide

    • same readme banner

    • also readme seems to be duplicated

  1. Ok and what about .editorConfig file. that also needs to be in root.

@derberg
Copy link
Member

derberg commented Apr 8, 2024

.editorConfig - yes, also in root

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please lemme know once you make changes and resolve conflicts

Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ayushnau ayushnau closed this by deleting the head repository Apr 11, 2024
@ayushnau
Copy link
Contributor Author

Acutually i was not able to get the changes in my branch. so need to refork it.

@ayushnau
Copy link
Contributor Author

This pr is moved to this #1186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How about a monorepo 😄
3 participants