Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build and publish docker image for arm and amd platforms #1004

Merged
merged 6 commits into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 30 additions & 15 deletions .github/workflows/release-docker.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Release Docker Image
on:
on:
release:
types:
types:
- published

jobs:
Expand All @@ -10,24 +10,39 @@ jobs:
name: Docker build and push
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2
with:
ref: master
- name: Get version without v character
id: version
run: |
VERSION=${{github.event.release.tag_name}}
VERSION_WITHOUT_V=${VERSION:1}
echo "::set-output name=value::$(echo $VERSION_WITHOUT_V)"
- name: Release to Docker
run: |
echo ${{secrets.DOCKER_PASSWORD}} | docker login -u ${{secrets.DOCKER_USERNAME}} --password-stdin
sleep 1m #docker image installs generator from npm, this sleep protects this step from any delays on npm side
derberg marked this conversation as resolved.
Show resolved Hide resolved
npm run docker:build
docker tag asyncapi/generator:latest asyncapi/generator:${{ steps.version.outputs.value }}
docker push asyncapi/generator:${{ steps.version.outputs.value }}
docker push asyncapi/generator:latest
echo "value=${VERSION_WITHOUT_V}" >> $GITHUB_OUTPUT

- name: Set Up QEMU
uses: docker/setup-qemu-action@v2

- name: Set Up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: login to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

# This workflow triggers on GitHub Release, but it may start before the npm package is published.
- name: Sleep for 1s seconds
run: sleep 1s

- name: Build Image
uses: docker/build-push-action@v4
with:
push: true
load: false
build-args: |
ASYNCAPI_GENERATOR_VERSION=${{ steps.version.outputs.value }}
tags: |
asyncapi/generator:${{ steps.version.outputs.value }}
asyncapi/generator:latest
platforms: linux/amd64,linux/arm64
cache-from: type=gha
cache-to: type=gha
Ferror marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 3 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
ARG ASYNCAPI_GENERATOR_VERSION=1.10.9

FROM node:14-alpine

WORKDIR /app
Expand All @@ -14,6 +16,6 @@ RUN apk --update add git chromium && \
rm /var/cache/apk/*

# Installing latest released npm package
RUN npm install -g @asyncapi/generator
RUN npm install -g @asyncapi/generator@$ASYNCAPI_GENERATOR_VERSION

ENTRYPOINT [ "ag" ]