Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump node-fetch to 2.7.0 #1048

Closed
wants to merge 1 commit into from

Conversation

drodil
Copy link

@drodil drodil commented Aug 2, 2024

Description

  • Use 2.7.0+ version of node-fetch that fixes bug with NodeJS20, see issue for more details

Related issue(s)

fixes #1047

Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: 611f1b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you add a changeset 🙂 #1048 (comment)

@smoya
Copy link
Member

smoya commented Nov 21, 2024

Friendly ping @drodil 🙏

@drodil
Copy link
Author

drodil commented Nov 21, 2024

@smoya thanks, been sick for long time, will check this latest next week!

@drodil drodil force-pushed the node_fetch branch 2 times, most recently from 1037bac to 953714e Compare November 25, 2024 20:07
@drodil drodil requested a review from jonaslagoni November 25, 2024 20:08
@drodil drodil closed this Nov 25, 2024
@drodil drodil deleted the node_fetch branch November 25, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Using old version of node-fetch causes issues with Node20
3 participants