Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dereference error does not include "title" #561

Closed
tim-lai opened this issue Jun 6, 2022 · 4 comments
Closed

Dereference error does not include "title" #561

tim-lai opened this issue Jun 6, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@tim-lai
Copy link

tim-lai commented Jun 6, 2022

Describe the bug

The dereferencing parser is not returning definition.refs.title, which is expected per ParserError.

How to Reproduce

  1. Go to https://studio.asyncapi.com/
  2. Introduce two $ref errors as seen in screenshot, e.g. line 32 and line 39.
  3. Expand the Problems pane

asyncapi-parser-deref-error

Expected behavior

A clear and concise description of what you expected to happen.

In the screenshot, one can see that the title referencing line 39 is incorrect. It should be Token "lightmeasured3" does not exist.

This visual error is because definition.title is being used instead of definition.refs[].title, but more importantly is that I can observe that definition.refs[].title itself doesn't exist as an output of the parser.

@tim-lai tim-lai added the bug Something isn't working label Jun 6, 2022
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@imabp
Copy link
Member

imabp commented Jul 10, 2022

Hey thanks for reporting that bug.
I could reproduce the error. I think, using the correct error index, will resolve the following issue.

title: err.errors[0].message,

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@magicmatatjahu
Copy link
Member

It is resolved in the asyncapi/studio#434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants