Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Implement custom schema parsing #859

Closed
Tracked by #953
smoya opened this issue Sep 7, 2023 · 4 comments
Closed
Tracked by #953

[v3] Implement custom schema parsing #859

smoya opened this issue Sep 7, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@smoya
Copy link
Member

smoya commented Sep 7, 2023

Describe the bug

I found out the following commented code https://github.com/asyncapi/parser-js/blob/next-major-spec/src/custom-operations/index.ts#L44-L47.

That means the call to parse() on custom schema parsers (Avro, OpenAPI, etc) is not being called for v3. That means schemas with those schema formats are never parsed. It also means users and tools won't be able to access to the transformed schema (we transform all of them to AsyncAPI Schema).

Expected behavior

The call to parse should be implemented.

cc @magicmatatjahu

@smoya smoya added the bug Something isn't working label Sep 7, 2023
@magicmatatjahu
Copy link
Member

It wasn't implemented because we had to wait to final version of schemas (exactly multiple schemas) in v3

@smoya
Copy link
Member Author

smoya commented Sep 15, 2023

This is then completely critical and requires to be implemented for the next release, otherwise schemas with a schema format different than AsyncAPI one won't be parsed, meaning raw schemas will be in place.

@smoya smoya changed the title [v3] Possible missing feature or bug [v3] Implement custom schema parsing Sep 15, 2023
@jonaslagoni
Copy link
Member

/progress 90 finished and ready to be reviewed

@jonaslagoni
Copy link
Member

Done in #864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants