feat: migrated the whole template to react #207
Conversation
ItshMoh
requested review from
CameronRushton and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
ItshMoh
changed the title
|
|
@derberg Hey ! can you review the PR. |
|
Hey @derberg can you review the PR? |
|
sorry mate for delay, will look into it |
|
|
||
| // If there are no schemas, we expect to find an anonymous one embedded in a payload. If we do have schemas we assume we don't need this. | ||
| // This will turn out to be a bug if we ever have a file with schemas, but which also has an anonymous schema embedded in an operation. | ||
| if (hasSchema) { |
There was a problem hiding this comment.
is it not needed because of convertToFilename implementation? why so?
or basically why template/payload.py is no longer needed
| @@ -0,0 +1,15 @@ | |||
| const sanitizeFilename = require('sanitize-filename'); | |||
|
|
|||
| function convertToFilename(string, options = { replacement: '-', maxLength: 255 }) { | |||
There was a problem hiding this comment.
why did you take this direction? did you face some issues while testing changes?
| @@ -0,0 +1,52 @@ | |||
| const _ = require('lodash'); | |||
There was a problem hiding this comment.
instead of partials people should rather opt in to use components reference for reusable components - more natively common word in the context of react and react components concept
Description
As part of the template to migrate it to v3, I have completed the migration to react renderer engine
https://www.loom.com/share/b59f39be60be436ab7eac2f6e13bf56a?sid=cf9dae72-5816-442a-8ce9-6ee320767c8d
Related issue(s)
Part of #189