-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use react-component in HTML template #88
Comments
Hey! You've labeled this issue as a Scope. Remember you can use the following command to inform about its progress:
or
Example:
🏋️♀️ See the progress on the Shape Up Dashboard. |
/progress 5 Starting task. First, I want to check if the current react component can be rendered as template. I'll give myself one day for it. It's only a premature-integration. Then I will start other tasks. |
/progress 25 I figured out how we can render component in HTML-template:
|
/progress 35 Create draft PR to show how we can integrate React component inside HTML template - asyncapi/html-template#166 |
/progress 45 In asyncapi/html-template#166 there is still work to be done:
I also want to try generate the page with Gatsby (suggested by Łukasz) and see if it reduces the template size. |
/progress 65 I wrote "stringify" function inside this PR. At the moment task is waiting for publishing "new" components with unified styling. |
/progress 80 Tested old parameters and it works with new component! Readme is also updated. Waiting to publish component. |
/progress 90 Waiting to publish component, also PR asyncapi/html-template#166 is ready to review! |
/progress 100 I think that review in asyncapi/html-template#166 is done. Fran accepted, only waiting for last thoughts from Łukasz :) Waiting to merge "new" component and bump it in html-template. |
After completing #85 #86 #87 HTML template should be replaced by react-component.
Written in #83
Also the HTML template supports some parameters like
singleFile
,baseHref
,version
,sidebarOrganization
, and others. We should make sure they still work.Ref: asyncapi/html-template#51
The text was updated successfully, but these errors were encountered: