Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way schemas are exported #367

Closed
smoya opened this issue Mar 23, 2023 · 0 comments · Fixed by #298
Closed

Change the way schemas are exported #367

smoya opened this issue Mar 23, 2023 · 0 comments · Fixed by #298

Comments

@smoya
Copy link
Member

smoya commented Mar 23, 2023

Part of asyncapi/parser-js#481

This change, once ported to next-major branch, will make https://github.com/asyncapi/parser-js/blob/next-major/src/schema-parser/asyncapi-schema-parser.ts#L38-L53 to provide wrong types.

TBH is not an issue with this PR per se. The way we are exporting the schemas is not helping. I think we could introduce the following separation in next-major branch:

declare const _exports: {
    'schemas': {
        // ...
    },
    'schemas-without-$id': {
        // ...
    }
}

Do you think it makes sense? If it does, +1 to merge this and start doing those changes in next-major.

cc @magicmatatjahu @jonaslagoni

Originally posted by @smoya in #298 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant