refactor: enable reusability of schemas between versions

[devilkiller-ag]

Description
Adding functionality to share these schemas to all versions:

• avroSchema_v1
• openapiSchema_3_0

Related issue(s)
Fixes #364

[github-actions]

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[devilkiller-ag]

This work is still in progress. I will update the tools/bundler/index.js soon to adapt these changes.

[devilkiller-ag]

Hi @jonaslagoni, The IIFE in the tools/bundler/index.js uses asyncapi.json of every version as fileToBundle. Why is it used for? And since the common folder will not have such a file, what should I use for fileToBundle? Or will I have to write a different implementation for this folder? I am sorry, I have a little blurry understanding of bundler and spec-json-schemas. Is there any resource which can help me to develop an understanding of this?

[jonaslagoni]

Hi @jonaslagoni, The IIFE in the tools/bundler/index.js uses asyncapi.json of every version as fileToBundle. Why is it used for?

It is the entry point for bundling, all references therein is being bundled recursively.

And since the common folder will not have such a file, what should I use for fileToBundle? Or will I have to write a different implementation for this folder? I am sorry, I have a little blurry understanding of bundler and spec-json-schemas. Is there any resource which can help me to develop an understanding of this?

The only changes you would need is something along the lines of; create a function for loadingCommonSchemas, which loops over all the files in the common folder, and adds them to the bundler memory. Similar to how the bindings are added:

spec-json-schemas/tools/bundler/index.js

Line 44 in 287ed28

async function loadBindings(bundler) {

Thats it. The rest of the bundler code should function fine after that.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[devilkiller-ag]

Hi @jonaslagoni, I am sorry for ghosting this PR. I will complete the work on it this weekend.

[devilkiller-ag]

Hi @jonaslagoni! Sorry for the delay. This PR is ready for review now!

[devilkiller-ag]

@jonaslagoni Any updates regarding this PR?

[jonaslagoni]

@devilkiller-ag you need to have the codeowners to look at it ✌️

[devilkiller-ag]

@jonaslagoni Got it✨

[devilkiller-ag]

Hi @derberg @fmvilas @smoya @dalelane @char0n, can you review this PR ✨

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[devilkiller-ag]

Hi @smoya, Can you please review this PR again?

[smoya]

LGTM! 🚀🌔

[smoya]

/rtm

[smoya]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀