fix: wrong validation with AsyncAPI v3 in VS Code and JetBrains IDEs #495

Pakisan · 2024-03-10T21:32:58Z

Fix specification validation erros in JetBrains and VS Code

Closes #494
Closes asyncapi/jasyncapi-idea-plugin#49

…erencing a a json schema Change allOf to anyOf in multiFormatSchema asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

github-actions

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

…erencing a a json schema Fix missing queue definition for SQS channel binding asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni

@Pakisan you need to adapt the definition files, not the bundled schemas 🙂

Pakisan · 2024-03-11T07:54:29Z

@Pakisan you need to adapt the definition files, not the bundled schemas 🙂

Yeah, expected this reply😅, because I saw that schemas were generated automatically

How to build schemas? I need to change only definitions?

jonaslagoni · 2024-03-11T08:03:37Z

@Pakisan you can run the npm command npm run bundle to trigger the bundling process.

Yep, only need to change the definitions, and everything else will be taken care of in the release process 🙂

Pakisan · 2024-03-11T08:36:30Z

@Pakisan you can run the npm command npm run bundle to trigger the bundling process.

Yep, only need to change the definitions, and everything else will be taken care of in the release process 🙂

It may be related with references availability?

I can open https://asyncapi.com/definitions/3.0.0/Reference.json, but can't https://www.asyncapi.com/bindings/sqs/0.2.0/channel.json

➜  ~ curl https://www.asyncapi.com/bindings/sqs/0.2.0/channel.json
<!DOCTYPE html><html lang="en"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width"/><meta name="next-head-count" content="2"/><link rel="preload" href="/_next/static/css/70fc8c1b3046a2a5.css" as="style"/><link rel="stylesheet" href="/_next/static/css/70fc8c1b3046a2a5.css" data-n-g=""/><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills-c67a75d1b6f99dc8.js"></script><script src="/_next/static/chunks/webpack-309fbebe2073f18c.js" defer=""></script><script src="/_next/static/chunks/framework-79bce4a3a540b080.js" defer=""></script><script src="/_next/static/chunks/main-5ab4e93313090fd8.js" defer=""></script><script src="/_next/static/chunks/pages/_app-e51460248b2aa259.js" defer=""></script><script src="/_next/static/chunks/pages/404-21869d41b96d4a23.js" defer=""></script><script src="/_next/static/uYuiB21UZi5IxEWUG1fEZ/_buildManifest.js" defer=""></script><script src="/_next/static/uYuiB21UZi5IxEWUG1fEZ/_ssgManifest.js" defer=""></script></head><body><div id="__next" data-reactroot=""></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/404","query":{},"buildId":"uYuiB21UZi5IxEWUG1fEZ","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script></body></html>%

Because SQS channels has right reference definition:

spec-json-schemas/bindings/sqs/0.2.0/channel.json

Lines 18 to 21 in 35ea790

    
           "deadLetterQueue": { 
        
             "description": "A definition of the queue that will be used for un-processable messages.", 
        
             "$ref": "http://asyncapi.com/bindings/sqs/0.2.0/channel.json#/definitions/queue" 
        
           },

which will be handled wrongly

spec-json-schemas/schemas/3.0.0-without-$id.json

Lines 5622 to 5625 in 35ea790

    
           "deadLetterQueue": { 
        
               "description": "A definition of the queue that will be used for un-processable messages.", 
        
               "$ref": "#/definitions/bindings-sqs-0.2.0-channel" 
        
           },

jonaslagoni · 2024-03-11T08:42:31Z

If you are using any of the schemas in https://github.com/asyncapi/spec-json-schemas/tree/master/schemas, you don't need to go remote to fetch the schemas, its only if you work with a definition for example.

The way the $id and $ref works in these definitions is that the bundler matches them locally, the same when you try to validate with the bundled schemas, that's simply part of the JSON Schema spec, that if a resource can be found locally that will be used.

So basically, just see the references as matching together, even if the remote URL does not exist 🙂 Even though it definitely should at some point

jonaslagoni · 2024-03-11T08:42:56Z

@smoya what do we need to change to publish the bindings publically?

…erencing a a json schema - Revert changes from auto generated schema - Change allOf to anyOf in multiFormatSchema asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

smoya · 2024-03-11T18:30:09Z

@jonaslagoni to either create a new or modify the following Netlify edge-function https://github.com/asyncapi/website/blob/master/netlify/edge-functions/serve-definitions.ts and add a new redirection rule into https://github.com/asyncapi/website/blob/master/netlify.toml

…erencing a json schema Include internal definitions from bindings to composed schema asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

…erencing a json schema fix linter issue asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

tools/bundler/index.js

…erencing a json schema Add clarification comment for fix asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni

Nice catch and fix 👌

As I am not codeowner someone else gotta have a look 😄

cc @GreenRover, @char0n, @dalelane, @derberg, @fmvilas, @smoya

Pakisan · 2024-03-12T13:36:33Z

@fmvilas @derberg @dalelane @smoya @char0n @GreenRover

Sorry for massive calling, but this issue affects users in VS Code and JetBrains IDEs

I checked fix here - https://www.jsonschemavalidator.net and inside my plugin

Because our cli is thinking that everything is ok with provided schemas - asyncapi/jasyncapi-idea-plugin#49 (comment)

GreenRover

i not understand the if then construct but the rest looks good.

Pakisan · 2024-03-27T11:21:54Z

@Pakisan would highly recommend splitting the bundler fix for bindings into a separate PR so it's not blocked by the continued discussion regarding multiformat schema object.

Main problem, after addition of new key word schemaFormat, is collisions between Schema, Json Schema, Avro Schema with weak constraints for additional properties. That's why I have added additionalProperties: false to Avro, for example

There really should be no collision when the validation occurs based on the conditioning of the value in schemaFormat 🤔 additionalProperties should have no effect other then for the schema format in use.

{
  "$id": "http://asyncapi.com/definitions/3.0.0/anySchema.json",
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "description": "An object representing either a Reference, a Schema or a Multi Format Schema",
  "properties": {
    "schemaFormat": {
      "type": "string",
      "description": "Supported Schema format"
    },
    "schema": {
      "type": "object",
      "description": "Schema definition"
    },
    "$ref": {
      "type": "string",
      "description": "Reference to schema"
    }
  },
  "oneOf": [
    {
      "description": "Because of $ref collision in Reference and AsyncAPI Schema(includes $ref from Json Schema)",
      "not": {"required": ["schemaFormat", "schema"]},
      "$ref": "http://asyncapi.com/definitions/3.0.0/schema.json"
    },
    {
      "type": "object",
      "required": ["schemaFormat", "schema"],
      "not": {"required": ["$ref"]},
      "minProperties": 2,
      "maxProperties": 2,
      "$ref": "http://asyncapi.com/definitions/3.0.0/multiFormatSchema.json"
    }
  ]
}

Here is simplified restriction to tell validator which schema to use. Our tests ok, because AJV is not in strict mode, but other validators, for example this will tell you that this two variants are satisfied:

It's because it checks:

multiFormatSchema requires this two fields - OK // expected
schema allows additional properties - OK // not expected

and as result, it tells that oneOf is not satisfied

jonaslagoni · 2024-03-27T11:38:44Z

@Pakisan I took a look at the old schemas and tested it locally which seems to work fine with just 3 changes.

remove disabling of additionalProperties:

spec-json-schemas/definitions/3.0.0/multiFormatSchema.json

Line 13 in bee34d8

"additionalProperties": false,
remove the property schema:

spec-json-schemas/definitions/3.0.0/multiFormatSchema.json

Line 53 in bee34d8

"schema": {
Remove clashing $ref for multiformat schema (i.e. when http://json-schema.org/draft-07/schema or http://asyncapi.com/definitions/3.0.0/schema.json is used only reference that and not http://asyncapi.com/definitions/3.0.0/Reference.json in union)

Full schema here:

{
  "description": "The Multi Format Schema Object represents a schema definition. It differs from the Schema Object in that it supports multiple schema formats or languages (e.g., JSON Schema, Avro, etc.).",
  "type": "object",
  "patternProperties": {
    "^x-[\\w\\d\\.\\x2d_]+$": {
      "$ref": "http://asyncapi.com/definitions/3.0.0/specificationExtension.json"
    }
  },
  "if": {
    "not": {
      "type": "object"
    }
  },
  "then": {
    "$ref": "http://asyncapi.com/definitions/3.0.0/schema.json"
  },
  "else": {
    "properties": {
      "schemaFormat": {
        "description": "A string containing the name of the schema format that is used to define the information. If schemaFormat is missing, it MUST default to application/vnd.aai.asyncapi+json;version={{asyncapi}} where {{asyncapi}} matches the AsyncAPI Version String. In such a case, this would make the Multi Format Schema Object equivalent to the Schema Object. When using Reference Object within the schema, the schemaFormat of the resource being referenced MUST match the schemaFormat of the schema that contains the initial reference. For example, if you reference Avro schema, then schemaFormat of referencing resource and the resource being reference MUST match.",
        "anyOf": [
          {
            "type": "string"
          },
          {
            "description": "All the schema formats tooling MUST support",
            "enum": [
              "application/schema+json;version=draft-07",
              "application/schema+yaml;version=draft-07",

              "application/vnd.aai.asyncapi;version=3.0.0",
              "application/vnd.aai.asyncapi+json;version=3.0.0",
              "application/vnd.aai.asyncapi+yaml;version=3.0.0"
            ]
          },
          {
            "description": "All the schema formats tools are RECOMMENDED to support",
            "enum": [
              "application/vnd.oai.openapi;version=3.0.0", 
              "application/vnd.oai.openapi+json;version=3.0.0", 
              "application/vnd.oai.openapi+yaml;version=3.0.0",

              "application/vnd.apache.avro;version=1.9.0",
              "application/vnd.apache.avro+json;version=1.9.0",
              "application/vnd.apache.avro+yaml;version=1.9.0",
              
              "application/raml+yaml;version=1.0"
            ]
          }
        ]
      }
    },
    "allOf": [
      {
        "if": {
          "not": {
            "description": "If no schemaFormat has been defined, default to schema or reference",
            "required": [
              "schemaFormat"
            ]
          }
        },
        "then": {
          "properties": {
            "schema": {
              "$ref": "http://asyncapi.com/definitions/3.0.0/schema.json"
            }
          }
        }
      },
      {
        "if": {
          "description": "If schemaFormat has been defined check if it's one of the AsyncAPI Schema Object formats",
          "required": [
            "schemaFormat"
          ],
          "properties": {
            "schemaFormat": {
              "enum": [
                "application/vnd.aai.asyncapi;version=2.0.0",
                "application/vnd.aai.asyncapi+json;version=2.0.0",
                "application/vnd.aai.asyncapi+yaml;version=2.0.0",
                "application/vnd.aai.asyncapi;version=2.1.0",
                "application/vnd.aai.asyncapi+json;version=2.1.0",
                "application/vnd.aai.asyncapi+yaml;version=2.1.0",
                "application/vnd.aai.asyncapi;version=2.2.0",
                "application/vnd.aai.asyncapi+json;version=2.2.0",
                "application/vnd.aai.asyncapi+yaml;version=2.2.0",
                "application/vnd.aai.asyncapi;version=2.3.0",
                "application/vnd.aai.asyncapi+json;version=2.3.0",
                "application/vnd.aai.asyncapi+yaml;version=2.3.0",
                "application/vnd.aai.asyncapi;version=2.4.0",
                "application/vnd.aai.asyncapi+json;version=2.4.0",
                "application/vnd.aai.asyncapi+yaml;version=2.4.0",
                "application/vnd.aai.asyncapi;version=2.5.0",
                "application/vnd.aai.asyncapi+json;version=2.5.0",
                "application/vnd.aai.asyncapi+yaml;version=2.5.0",
                "application/vnd.aai.asyncapi;version=2.6.0",
                "application/vnd.aai.asyncapi+json;version=2.6.0",
                "application/vnd.aai.asyncapi+yaml;version=2.6.0",
                "application/vnd.aai.asyncapi;version=3.0.0",
                "application/vnd.aai.asyncapi+json;version=3.0.0",
                "application/vnd.aai.asyncapi+yaml;version=3.0.0"
              ]
            }
          }
        },
        "then": {
          "properties": {
            "schema": {
              "$ref": "http://asyncapi.com/definitions/3.0.0/schema.json"
            }
          }
        }
      },
      {
        "if": {
          "required": [
            "schemaFormat"
          ],
          "properties": {
            "schemaFormat": {
              "enum": [
                "application/schema+json;version=draft-07",
                "application/schema+yaml;version=draft-07"
              ]
            }
          }
        },
        "then": {
          "properties": {
            "schema": {
              "$ref": "http://json-schema.org/draft-07/schema"
            }
          }
        }
      },
      {
        "if": {
          "required": [
            "schemaFormat"
          ],
          "properties": {
            "schemaFormat": {
              "enum": [
                "application/vnd.oai.openapi;version=3.0.0",
                "application/vnd.oai.openapi+json;version=3.0.0",
                "application/vnd.oai.openapi+yaml;version=3.0.0"
              ]
            }
          }
        },
        "then": {
          "properties": {
            "schema": {
              "oneOf": [
                {
                  "$ref": "http://asyncapi.com/definitions/3.0.0/Reference.json"
                },
                {
                  "$ref": "http://asyncapi.com/definitions/3.0.0/openapiSchema_3_0.json"
                }
              ]
            }
          }
        }
      },
      {
        "if": {
          "required": [
            "schemaFormat"
          ],
          "properties": {
            "schemaFormat": {
              "enum": [
                "application/vnd.apache.avro;version=1.9.0",
                "application/vnd.apache.avro+json;version=1.9.0",
                "application/vnd.apache.avro+yaml;version=1.9.0"
              ]
            }
          }
        },
        "then": {
          "properties": {
            "schema": {
              "oneOf": [
                {
                  "$ref": "http://asyncapi.com/definitions/3.0.0/Reference.json"
                },
                {
                  "$ref": "http://asyncapi.com/definitions/3.0.0/avroSchema_v1.json"
                }
              ]
            }
          }
        }
      }
    ]
  },
  "$schema": "http://json-schema.org/draft-07/schema#",
  "$id": "http://asyncapi.com/definitions/3.0.0/multiFormatSchema.json"
}

I tested it locally with Avro and OpenAPI references and it seems to have solved the problem without having to do major refactorings. Mind giving it a test?

jonaslagoni · 2024-03-27T11:54:00Z

Technically we could add the following to anySchema:

spec-json-schemas/definitions/3.0.0/anySchema.json

Line 10 in bee34d8

"else": {

  "else": {
    "oneOf": [
      {
        "$ref": "http://asyncapi.com/definitions/3.0.0/Reference.json"
      },
      {
        "$ref": "http://asyncapi.com/definitions/3.0.0/schema.json"
      }
    ]
  },

However, because http://asyncapi.com/definitions/3.0.0/schema.json references http://json-schema.org/draft-07/schema that already contains $ref property, it's not really needed.

Scratch that, it classes with #495 (comment), better not to use double meaning for $ref if we can avoid it as described in #495 (comment)

Pakisan · 2024-03-27T12:05:12Z

@jonaslagoni add from my revision(a4c5ef0) all test specifications

jonaslagoni · 2024-03-27T12:10:07Z

@Pakisan testing with them now

jonaslagoni · 2024-03-27T12:17:59Z

@Pakisan all seem to pass with the changes in #495 (comment)

I can run npm run test with no problem and manually tested one of them.

definitions/3.0.0/components.json

Pakisan · 2024-03-27T12:22:33Z

@Pakisan all seem to pass with the changes in #495 (comment)

I can run npm run test with no problem and manually tested one of them.

Yep. I found that related MR is fix, not replacement for current. Let me apply your changes and check them

…erencing a json schema New multiFormatSchema validation rules asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

Pakisan · 2024-03-28T14:02:33Z

@jonaslagoni applied your changes

#495 (comment)

…erencing a json schema New multiFormatSchema validation rules asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

definitions/3.0.0/anySchema.json

jonaslagoni · 2024-03-29T08:20:23Z

definitions/3.0.0/multiFormatSchema.json

+    "^x-[\\w\\d\\.\\x2d_]+$": {
+      "$ref": "http://asyncapi.com/definitions/3.0.0/specificationExtension.json"
+    }
+  },
  "if": {


If you want, feel free to remove this if/then as #507 does ✌️

jonaslagoni · 2024-03-29T08:22:30Z

common/avroSchema_v1.json

@@ -70,7 +70,8 @@
      },
      "required": [
        "type"
-      ]
+      ],
+      "additionalProperties": false


I dont think these changes with additionalProperties is necessary, and on the other side, are you not allowed to have additional properties in Avro? 🤔

As I remember Avro is allows only defined attributes. For example Record - https://avro.apache.org/docs/1.11.1/specification/#schema-record

Seems like additional properties is allowed on the different levels of Avro: https://asyncapi.slack.com/archives/C0230UAM6R3/p1712059889567579?thread_ts=1711713980.293369&cid=C0230UAM6R3

I removed restriction

…erencing a json schema New multiFormatSchema validation rules asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni · 2024-03-29T12:03:03Z

definitions/3.0.0/anySchema.json

 {
-  "if": {
-    "required": [
-      "schema"
-    ]
-  },
-  "then": {
-    "$ref": "http://asyncapi.com/definitions/3.0.0/multiFormatSchema.json"
-  },
-  "else": {
-    "$ref": "http://asyncapi.com/definitions/3.0.0/schema.json"
-  },
-  "description": "An object representing either a schema or a multiFormatSchema based on the existence of the 'schema' property. If the property 'schema' is present, use the multi-format schema. Use the default AsyncAPI Schema otherwise.",
+  "$id": "http://asyncapi.com/definitions/3.0.0/anySchema.json",
  "$schema": "http://json-schema.org/draft-07/schema#",
-  "$id": "http://asyncapi.com/definitions/3.0.0/anySchema.json"
+  "type": "object",
+  "description": "An object representing either a Reference, a Schema or a Multi Format Schema",
+  "oneOf": [
+    {
+      "description": "Because of $ref collision in Reference and AsyncAPI Schema(includes $ref from Json Schema)",
+      "not": {"required": ["schemaFormat", "schema"]},
+      "$ref": "http://asyncapi.com/definitions/3.0.0/schema.json"
+    },
+    {
+      "type": "object",
+      "required": ["schemaFormat", "schema"],
+      "not": {"required": ["$ref"]},
+      "minProperties": 2,
+      "maxProperties": 2,
+      "$ref": "http://asyncapi.com/definitions/3.0.0/multiFormatSchema.json"
+    }
+  ]


Meant the entire thing @Pakisan, anySchema does not need any changes to work 🙂

…erencing a json schema Rollback AnySchema and AvroSchema asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni

👍

sonarqubecloud · 2024-04-03T10:05:56Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

smoya

LGTM! 🚀🌔

Thanks for all the time invested in solving this issue @Pakisan. We all had to do a very focused review on this but finally got sorted out 🙌

Thanks @jonaslagoni as well for your second review.

smoya · 2024-04-03T14:18:24Z

/rtm

asyncapi-bot · 2024-04-03T14:27:12Z

🎉 This PR is included in version 6.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

0396524

…erencing a a json schema Change allOf to anyOf in multiFormatSchema asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

Pakisan requested review from fmvilas, derberg, dalelane, smoya, char0n, asyncapi-bot-eve and GreenRover as code owners March 10, 2024 21:32

github-actions bot reviewed Mar 10, 2024

View reviewed changes

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

8af32be

…erencing a a json schema Fix missing queue definition for SQS channel binding asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni requested changes Mar 11, 2024

View reviewed changes

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

518e3e0

…erencing a a json schema - Revert changes from auto generated schema - Change allOf to anyOf in multiFormatSchema asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

Pakisan and others added 2 commits March 12, 2024 15:49

Merge branch 'master' into fix/494

78ce54d

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

b5f2139

…erencing a json schema Include internal definitions from bindings to composed schema asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

Pakisan requested a review from jonaslagoni March 12, 2024 13:06

Pakisan changed the title ~~WIP: fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…~~ fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref… Mar 12, 2024

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

87a6097

…erencing a json schema fix linter issue asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni reviewed Mar 12, 2024

View reviewed changes

tools/bundler/index.js Show resolved Hide resolved

Pakisan changed the title ~~fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…~~ fix: wrong validation with AsyncAPI v3 in VS Code and JetBrains IDEs Mar 12, 2024

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

981c80d

…erencing a json schema Add clarification comment for fix asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni approved these changes Mar 12, 2024

View reviewed changes

GreenRover previously approved these changes Mar 12, 2024

View reviewed changes

dalelane previously approved these changes Mar 14, 2024

View reviewed changes

jonaslagoni mentioned this pull request Mar 27, 2024

chore: remove unnecessary validation check for multi format schema #507

Closed

jonaslagoni reviewed Mar 27, 2024

View reviewed changes

definitions/3.0.0/components.json Show resolved Hide resolved

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

469431c

…erencing a json schema New multiFormatSchema validation rules asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

Pakisan requested a review from jonaslagoni March 28, 2024 14:07

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

b45e610

…erencing a json schema New multiFormatSchema validation rules asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni requested changes Mar 29, 2024

View reviewed changes

jonaslagoni mentioned this pull request Mar 29, 2024

Bug in bundler. Schema properties are wrong in at least 2.0.0-rc1-without-$id.json #454

Open

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

52b06c5

…erencing a json schema New multiFormatSchema validation rules asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni requested changes Mar 29, 2024

View reviewed changes

Pakisan added 2 commits April 2, 2024 22:31

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

d34130d

…erencing a json schema Rollback AnySchema and AvroSchema asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

fix: AsyncAPI v3 shows warning in Studio and IntelliJ plugin when ref…

a9a7d47

…erencing a json schema Rollback AnySchema and AvroSchema asyncapi#494 asyncapi/jasyncapi-idea-plugin#49

jonaslagoni approved these changes Apr 3, 2024

View reviewed changes

Merge branch 'master' into fix/494

eba77ed

smoya approved these changes Apr 3, 2024

View reviewed changes

asyncapi-bot added the ready-to-merge label Apr 3, 2024

smoya removed the do-not-merge label Apr 3, 2024

asyncapi-bot merged commit d58bf5e into asyncapi:master Apr 3, 2024
11 checks passed

asyncapi-bot added the released label Apr 3, 2024

smoya mentioned this pull request Apr 3, 2024

Acceptance criteria for new maintainers #513

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: wrong validation with AsyncAPI v3 in VS Code and JetBrains IDEs #495

fix: wrong validation with AsyncAPI v3 in VS Code and JetBrains IDEs #495

Pakisan commented Mar 10, 2024 •

edited

Loading

github-actions bot left a comment

jonaslagoni left a comment •

edited

Loading

Pakisan commented Mar 11, 2024 •

edited

Loading

jonaslagoni commented Mar 11, 2024 •

edited

Loading

Pakisan commented Mar 11, 2024

jonaslagoni commented Mar 11, 2024

jonaslagoni commented Mar 11, 2024

smoya commented Mar 11, 2024

jonaslagoni left a comment •

edited

Loading

Pakisan commented Mar 12, 2024

GreenRover left a comment

Pakisan commented Mar 27, 2024

jonaslagoni commented Mar 27, 2024 •

edited

Loading

jonaslagoni commented Mar 27, 2024 •

edited

Loading

Pakisan commented Mar 27, 2024 •

edited

Loading

jonaslagoni commented Mar 27, 2024

jonaslagoni commented Mar 27, 2024

Pakisan commented Mar 27, 2024

Pakisan commented Mar 28, 2024

jonaslagoni Mar 29, 2024

jonaslagoni Mar 29, 2024

Pakisan Mar 29, 2024

jonaslagoni Apr 2, 2024

Pakisan Apr 2, 2024

jonaslagoni Mar 29, 2024

Pakisan Apr 2, 2024

jonaslagoni left a comment

sonarqubecloud bot commented Apr 3, 2024

smoya left a comment

smoya commented Apr 3, 2024

asyncapi-bot commented Apr 3, 2024

fix: wrong validation with AsyncAPI v3 in VS Code and JetBrains IDEs #495

fix: wrong validation with AsyncAPI v3 in VS Code and JetBrains IDEs #495

Conversation

Pakisan commented Mar 10, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

jonaslagoni left a comment • edited Loading

Choose a reason for hiding this comment

Pakisan commented Mar 11, 2024 • edited Loading

jonaslagoni commented Mar 11, 2024 • edited Loading

Pakisan commented Mar 11, 2024

jonaslagoni commented Mar 11, 2024

jonaslagoni commented Mar 11, 2024

smoya commented Mar 11, 2024

jonaslagoni left a comment • edited Loading

Choose a reason for hiding this comment

Pakisan commented Mar 12, 2024

GreenRover left a comment

Choose a reason for hiding this comment

Pakisan commented Mar 27, 2024

jonaslagoni commented Mar 27, 2024 • edited Loading

jonaslagoni commented Mar 27, 2024 • edited Loading

Pakisan commented Mar 27, 2024 • edited Loading

jonaslagoni commented Mar 27, 2024

jonaslagoni commented Mar 27, 2024

Pakisan commented Mar 27, 2024

Pakisan commented Mar 28, 2024

jonaslagoni Mar 29, 2024

Choose a reason for hiding this comment

jonaslagoni Mar 29, 2024

Choose a reason for hiding this comment

Pakisan Mar 29, 2024

Choose a reason for hiding this comment

jonaslagoni Apr 2, 2024

Choose a reason for hiding this comment

Pakisan Apr 2, 2024

Choose a reason for hiding this comment

jonaslagoni Mar 29, 2024

Choose a reason for hiding this comment

Pakisan Apr 2, 2024

Choose a reason for hiding this comment

jonaslagoni left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Apr 3, 2024

Quality Gate passed

smoya left a comment

Choose a reason for hiding this comment

smoya commented Apr 3, 2024

asyncapi-bot commented Apr 3, 2024

Pakisan commented Mar 10, 2024 •

edited

Loading

jonaslagoni left a comment •

edited

Loading

Pakisan commented Mar 11, 2024 •

edited

Loading

jonaslagoni commented Mar 11, 2024 •

edited

Loading

jonaslagoni left a comment •

edited

Loading

jonaslagoni commented Mar 27, 2024 •

edited

Loading

jonaslagoni commented Mar 27, 2024 •

edited

Loading

Pakisan commented Mar 27, 2024 •

edited

Loading