-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded tags support: allow adding tags to more entities, support refs #750
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
@gabormagyar can you specify where exactly you would like to see I also understand you'd like to have it also in components so it can be refed from other parts of the document |
Right now I have most of my channels looking like this: subscribe:
message:
payload:
$ref: @schemas/payload.yml
publish:
description: Description
message:
payload:
$ref: @schemas/payload.yml
tags:
- {{ mixin('@tags/producer-driven.yml.njk') }}
subscribe:
message:
payload:
$ref: ../../../components/schemas/payload.yml
tags:
- name: tag-name
description: >-
Tag description
externalDocs:
description: More info
url: >-
https://github.com/.../README.md
publish:
description: Description
message:
payload:
$ref: ../../../components/schemas/payload.yml
tags:
- name: tag-name
description: >-
Tag description
externalDocs:
description: More info
url: >-
https://github.com/.../README.md |
FYI, #809 adds support for Tags at Server Object level. |
Adding tags on |
Reusable |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Tags are great! I see two low hanging improvements that could be made to them:
Refs
Tags could be added under
components
, and could be referenced in other places so that tags (potentially with documentation and info links) don't have to be duplicated across usagesMore entities
I tried to add tags to schemas, but the parser told me that that was invalid. I see no reason to disallow this. Should probably consider other places where tags may be applicable.
Relevant slack thread with @magicmatatjahu: https://asyncapi.slack.com/archives/CQVJXFNQL/p1649332581535119
The text was updated successfully, but these errors were encountered: