Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update release workflow in release branch #938

Closed
derberg opened this issue May 24, 2023 · 6 comments · Fixed by #939
Closed

update release workflow in release branch #938

derberg opened this issue May 24, 2023 · 6 comments · Fixed by #939
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue released on @next-major-spec released

Comments

@derberg
Copy link
Member

derberg commented May 24, 2023

Release https://github.com/asyncapi/spec/blob/next-major-spec/.github/workflows/release.yml needs update

Because of https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

      - name: Setup Node.js
        uses: actions/setup-node@v1

needs to be replaced with

- name: Setup Node.js
   uses: actions/setup-node@v3
   with:
      node-version: 18

also

npm install conventional-changelog-conventionalcommits

update to

npm install --save-dev [email protected]

and switch:

actions/checkout@v2

to

actions/checkout@v3
@derberg
Copy link
Member Author

derberg commented May 24, 2023

/gfi ci-cd

@asyncapi-bot asyncapi-bot added area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue labels May 24, 2023
@kaushik-rishi
Copy link
Contributor

@derberg let's say i made the contribution, how would we generally test these out ? just by triggering the workflow ?

@kaushik-rishi kaushik-rishi mentioned this issue May 24, 2023
Merged
@kaushik-rishi
Copy link
Contributor

Also, this PR/commit should be a chore and not a feat right ?

@derberg
Copy link
Member Author

derberg commented Jun 28, 2023

just by triggering the workflow ?

only way is to get it to some test repo and test it there 🤷🏼

Also, this PR/commit should be a chore and not a feat right ?

ci 😉

@kaushik-rishi kaushik-rishi mentioned this issue Jul 25, 2023
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: update release workflow kaushik-rishi/spec
3 participants
@derberg @kaushik-rishi @asyncapi-bot