fix: file write errors for tools and newsroom video (#3297)

Co-authored-by: Ansh Goyal <[email protected]>

package.json

@@ -70,6 +70,7 @@
     "clsx": "^2.1.0",
     "cssnano": "^6.0.3",
     "dotenv": "^16.4.4",
+    "fs-extra": "^11.2.0",
     "fuse.js": "^7.0.0",
     "googleapis": "^133.0.0",
     "gray-matter": "^4.0.3",

scripts/build-newsroom-videos.js

@@ -1,4 +1,4 @@
-const { writeFileSync } = require('fs');
+const { writeFileSync } = require('fs-extra');
 const { resolve } = require('path');
 const fetch = require('node-fetch-2');
 
@@ -19,7 +19,7 @@ async function buildNewsroomVideos(writePath) {
         }
 
         const data = await response.json();
-        console.log(data)
+        console.log(data);
 
         if (!data.items || !Array.isArray(data.items)) {
             throw new Error('Invalid data structure received from YouTube API');

scripts/build-tools.js

@@ -1,18 +1,15 @@
 const { getData } = require('./tools/extract-tools-github');
 const { convertTools } = require('./tools/tools-object');
 const { combineTools } = require('./tools/combine-tools');
-const fs = require('fs');
+const fs = require('fs-extra');
 const { resolve } = require('path');
 
 const buildTools = async (automatedToolsPath, manualToolsPath, toolsPath, tagsPath) => {
   try {
     let githubExtractData = await getData();
     let automatedTools = await convertTools(githubExtractData);
 
-    fs.writeFileSync(
-      automatedToolsPath,
-      JSON.stringify(automatedTools, null, '  ')
-    );
+    await fs.writeFile(automatedToolsPath, JSON.stringify(automatedTools, null, '  '));
 
     await combineTools(automatedTools, require(manualToolsPath), toolsPath, tagsPath);
   } catch (err) {

tests/build-newsroom-videos.test.js

@@ -1,22 +1,23 @@
-const { readFileSync, rmSync, mkdirSync } = require('fs');
-const { resolve } = require('path');
+const { readFileSync, removeSync, mkdirpSync } = require('fs-extra');
+const { resolve, join } = require('path');
 const { buildNewsroomVideos } = require('../scripts/build-newsroom-videos');
 const { mockApiResponse, expectedResult } = require('./fixtures/newsroomData');
 const fetch = require('node-fetch-2');
+const os = require('os');
 
 jest.mock('node-fetch-2', () => jest.fn());
 
 describe('buildNewsroomVideos', () => {
-    const testDir = resolve(__dirname, 'test_config');
+    const testDir = join(os.tmpdir(), 'test_config');
     const testFilePath = resolve(testDir, 'newsroom_videos.json');
 
     beforeAll(() => {
-        mkdirSync(testDir, { recursive: true });
+        mkdirpSync(testDir);
         process.env.YOUTUBE_TOKEN = 'testkey';
     });
 
     afterAll(() => {
-        rmSync(testDir, { recursive: true, force: true });
+        removeSync(testDir);
     });
 
     beforeEach(() => {
@@ -89,13 +90,12 @@ describe('buildNewsroomVideos', () => {
             json: jest.fn().mockResolvedValue(mockApiResponse),
         });
 
-        const invalidPath = '/invalid_dir/newsroom_videos.json';
+        const invalidPath = resolve(os.tmpdir(), 'invalid_dir', 'newsroom_videos.json');
 
         try {
             await buildNewsroomVideos(invalidPath);
         } catch (err) {
             expect(err.message).toMatch(/ENOENT|EACCES/);
         }
     });
-
 });

tests/build-tools.test.js

@@ -2,7 +2,9 @@ const axios = require('axios');
 const { resolve } = require('path');
 const { buildTools } = require('../scripts/build-tools');
 const { tagsData, manualTools, mockConvertedData, mockExtractData } = require('../tests/fixtures/buildToolsData');
-const fs = require('fs');
+const fs = require('fs-extra');
+const os = require('os');
+const path = require('path');
 
 jest.mock('axios');
 jest.mock('../scripts/tools/categorylist', () => ({
@@ -24,19 +26,22 @@ jest.mock('../scripts/tools/tags-color', () => ({
 }));
 
 describe('buildTools', () => {
-    const testDir = resolve(__dirname, 'test_config');
+    const testDir = path.join(os.tmpdir(), 'test_config');
     const toolsPath = resolve(testDir, 'tools.json');
     const tagsPath = resolve(testDir, 'all-tags.json');
     const automatedToolsPath = resolve(testDir, 'tools-automated.json');
     const manualToolsPath = resolve(testDir, 'tools-manual.json');
+    let consoleErrorMock;
 
     beforeAll(() => {
-        fs.mkdirSync(testDir, { recursive: true });
-        fs.writeFileSync(manualToolsPath, JSON.stringify(manualTools));
+        consoleErrorMock = jest.spyOn(console, 'error').mockImplementation(() => {});
+        fs.ensureDirSync(testDir);
+        fs.outputFileSync(manualToolsPath, JSON.stringify(manualTools));
     });
 
     afterAll(() => {
-        fs.rmSync(testDir, { recursive: true, force: true });
+        fs.removeSync(testDir);
+        consoleErrorMock.mockRestore();
     });
 
     beforeEach(() => {
@@ -62,7 +67,6 @@ describe('buildTools', () => {
         expect(combinedToolsContent["Category2"].description).toEqual(mockConvertedData["Category2"].description);
 
         expect(tagsContent).toEqual(tagsData);
-
     });
 
     it('should handle getData error', async () => {
@@ -78,7 +82,7 @@ describe('buildTools', () => {
     it('should handle file write errors', async () => {
         axios.get.mockResolvedValue({ data: mockExtractData });
 
-        const invalidPath = '/invalid_dir/tools.json';
+        const invalidPath = path.resolve(os.tmpdir(), 'invalid_dir', 'tools.json');
 
         try {
             await buildTools(invalidPath, manualToolsPath, toolsPath, tagsPath);