Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Sidebar #1582

Closed
Sukriti-sood opened this issue Apr 15, 2023 · 16 comments
Closed

Docs Sidebar #1582

Sukriti-sood opened this issue Apr 15, 2023 · 16 comments
Labels
bug Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com

Comments

@Sukriti-sood
Copy link

Sukriti-sood commented Apr 15, 2023

Describe the bug

Whenever we open a docs subitem, the contents load, but the side bar doesn't scroll down.

How to Reproduce

Introduction-AsyncAPI-Initiative-for-event-driven-APIs.webm

I think it's an important bug that needs to be fixed, since there are no triggers or a lot of visual changes happening with the change of content. So animation is needed, and if the sidebar scrolls to that subitem heading, the problem will be resolved.

@alequetzalli

@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@akshatnema
Copy link
Member

akshatnema commented Apr 15, 2023

@Sukriti-sood Do you mean that if we click on the subitems in DocsMenu, the DocsSidebar should also scroll down to that heading?

@Sukriti-sood
Copy link
Author

@Sukriti-sood Do you mean that if we click on the subitems in DocsMenu, the DocsSidebar should also scroll down to that heading?

Yes.

@akshatnema
Copy link
Member

@Sukriti-sood Yepp it's a good UI issue and should be resolved. Will you like to work on it?

@Sukriti-sood
Copy link
Author

@Sukriti-sood Yepp it's a good UI issue and should be resolved. Will you like to work on it?

yes

@niranjan-kurhade
Copy link
Contributor

@Sukriti-sood Do you mean that if we click on the subitems in DocsMenu, the DocsSidebar should also scroll down to that heading?

Yes.

@Sukriti-sood Are you working on this issue?

@Sukriti-sood
Copy link
Author

@Sukriti-sood Do you mean that if we click on the subitems in DocsMenu, the DocsSidebar should also scroll down to that heading?

Yes.

@Sukriti-sood Are you working on this issue?

Not working currently.

@Savio629
Copy link
Contributor

@Sukriti-sood If you are not working on it @niranjan-kurhade you can take up this issue

@anj20
Copy link

anj20 commented May 12, 2023

@Savio629 if no one is working on this can I take this issue?

@Savio629
Copy link
Contributor

@anj20 Yeah go ahead..

@anj20
Copy link

anj20 commented May 13, 2023

Sent the pr...Can you review it @Savio629
#1665

@Priyansh61
Copy link

Hi @anj20, Just a tip here, we can solve the issue just by adding an useEffect (#1668) hook and making the scroll possible on change. So can you please help me like why do we need to make such a large change in the codebase for this as mentioned in #1665?

Thanks,

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 11, 2023
@akshatnema akshatnema added Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com and removed stale labels Sep 27, 2023
@KaalCodes
Copy link

hello... Everyone we can solve this problem by using smoothScroll effect.

@akshatnema
Copy link
Member

@KaalCodes Go for it and open the PR after you made the changes 🚀

@sambhavgupta0705
Copy link
Member

Closing this issue as the whole UI has been reformed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants