Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: No form validation in Subscribe to our newsletter to receive news about AsyncAPI in home Page #2125

Open
love-sonkar opened this issue Sep 6, 2023 · 23 comments
Labels

Comments

@love-sonkar
Copy link

Describe the bug

In Home page we have a Subscribe to our newsletter to receive news about AsyncAPI form and there is no validation for email and name.

How to Reproduce

Go to home page scroll down to subscribe to newsletter form and randomly enter any email or name then click on subscribe button.

  • Screenshots
    ss
chrome_29HnFrVdJ7.mp4

Expected behavior

Form must be completely valid
like email must be a valid email address.
and name must contain 3 or 4 character minimum.

@love-sonkar love-sonkar added the bug label Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Vikram125609
Copy link

Can anyone please assign this to me ?
We can use RegExp to validate the email and name

@Om2123
Copy link

Om2123 commented Sep 10, 2023

i think regExp won't work , it can't validate whether domain exits or not . Email validation api's like reacher , truemail would work

Copy link
Member

derberg commented Sep 13, 2023

yeah regex won't work.
but is it a real issue? we are not getting any spam subscriptions. People usually don't do it to open source communities.

also can't be nicely completed until we get #1091

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jan 12, 2024
@sambhavgupta0705
Copy link
Member

@derberg @akshatnema should we go ahead with this issue ??

@github-actions github-actions bot removed the stale label Feb 24, 2024
@akshatnema
Copy link
Member

Yeah, we can go ahead with this issue.

@AKACHI-4
Copy link

AKACHI-4 commented Mar 1, 2024

@akshatnema, can I take it and work on it? All I need is to research around the Email validation API to verify the name and email of whoever is entering it.

@sambhavgupta0705
Copy link
Member

yeahhh you may work on this one

@sambhavgupta0705
Copy link
Member

@AKACHI-4 any update

@AKACHI-4
Copy link

AKACHI-4 commented Mar 5, 2024

Yeah, I looked into various validation APIs, and man, it was kinda time taking. Some of them have pricing issues... However, I tried using Postman to call their API, and everything went smoothly... After all, I decided to go with ZeroBounce because they provide free 100 email validations per month, which is definitely a good choice.

What I'm planning to do now is

  • Implement email validation directly into the NewsletterSubscribe.js file before fetching from the Netlify function.
  • Regarding the mentioned issue, I encountered the same thing initially while checking. I guess it's from the function's side.
  • For now, I commented out that part so I can focus on implementing validation only. But I'll definitely look into it.

Here's the image I was using :-
I tried usebouncer for checking, but I'm getting some CORS errors though. I'll resolve them and try to push the changes as soon as possible.

image

@sambhavgupta0705
Copy link
Member

Ohkkk great!!

@sambhavgupta0705
Copy link
Member

Raise a PR when you are done with the work

@AKACHI-4
Copy link

AKACHI-4 commented Mar 8, 2024

Hey @sambhavgupta0705 .. I am done with the changes. kindly review it and guide for further in steps.

Copy link

github-actions bot commented Jul 7, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 7, 2024
@JeelRajodiya
Copy link
Contributor

JeelRajodiya commented Sep 7, 2024

@sambhavgupta0705 Is this issue still relevant? I would like to work on it.

@github-actions github-actions bot removed the stale label Sep 8, 2024
@sambhavgupta0705
Copy link
Member

@sambhavgupta0705 Is this issue still relevant? I would like to work on it.

yes you may

@Pruthvik-P
Copy link

can i work on it?

@JeelRajodiya
Copy link
Contributor

can i work on it?

I am currently not working on the issue, because of my exams. If you want you can start working on it :)

@TejasSaraf
Copy link

Hey @sambhavgupta0705, I want to work on this issue an you please assign it to me?

@ParagGhatage
Copy link

Hi @love-sonkar ,
I just checked the AsyncAPI website, and it seems this issue is still present. I’d love to work on it if it's available. Let me know!

@ParagGhatage
Copy link

Hi @derberg ,
Please take a look at this solution and let me know if any changes are needed.

Validation Changes for Email and Name Inputs

Summary

I added validation for the email and name input fields, ensuring error messages are displayed directly below their respective input fields for better clarity.

Changes:

  1. Email & Name Validation: Both fields now validate the input on change. If invalid:

    • Email checks if it matches the proper format.
    • Name checks if it has a minimum of 3 characters.
  2. Error Message Placement:

    • Error messages are shown directly below the relevant input field.
Untitled.video.-.Made.with.Clipchamp.1.mp4

Please assign this issue to me, and I will submit the PR once the changes are approved.

@ParagGhatage
Copy link

Hi @derberg , Please take a look at this solution and let me know if any changes are needed.

Validation Changes for Email and Name Inputs

Summary

I added validation for the email and name input fields, ensuring error messages are displayed directly below their respective input fields for better clarity.

Changes:

  1. Email & Name Validation: Both fields now validate the input on change. If invalid:

    • Email checks if it matches the proper format.
    • Name checks if it has a minimum of 3 characters.
  2. Error Message Placement:

    • Error messages are shown directly below the relevant input field.

Untitled.video.-.Made.with.Clipchamp.1.mp4
Please assign this issue to me, and I will submit the PR once the changes are approved.

@derberg , @akshatnema please review above changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.