Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new setup of website with Next js + Typescript #2710

Merged
merged 62 commits into from
May 27, 2024
Merged

Conversation

akshatnema
Copy link
Member

Description

This PR is initiated to merge the updated changes from master to migrate-ts. Hence, no review is required until this is ready for merging in master.

Related issue(s)

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 6dfa8a2
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66547d7c531f8200085f7631
😎 Deploy Preview https://deploy-preview-2710--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented May 14, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 45
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-2710--asyncapi-website.netlify.app/

@quetzalliwrites
Copy link
Member

Confirming stuff looks good on my end and the docs look normal ✌🏽🪄

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Co-authored-by: Akshat Nema <[email protected]>%0ACo-authored-by: Quetzalli <[email protected]>
@derberg
Copy link
Member

derberg commented May 20, 2024

some strange duplicate at https://deploy-preview-2710--asyncapi-website.netlify.app/finance that is not on prod

Screenshot 2024-05-20 at 09 07 52

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!✅

anshgoyalevil
anshgoyalevil previously approved these changes May 25, 2024
Copy link
Member

@anshgoyalevil anshgoyalevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The website looks great. Some reported issues under the ticket #2924 doesn't seem like a blocker for this PR and can be tackled under the separate PRs after merging it into master.

🚢

@akshatnema
Copy link
Member Author

We need final approval from @derberg @alequetzalli.

@akshatnema
Copy link
Member Author

Since @derberg is OOTO and @alequetzalli @anshgoyalevil approved it previously, I'm going to merge it manually now. Hopefully, it doesn't break anything 🤞

@akshatnema akshatnema merged commit 80a29fe into master May 27, 2024
15 checks passed
@akshatnema akshatnema deleted the migrate-ts branch October 1, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.