-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new setup of website with Next js + Typescript #2710
Conversation
Co-authored-by: Ansh Goyal <[email protected]>
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Akshat Nema <[email protected]>%0ACo-authored-by: akshatnema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>%0ACo-authored-by: akshatnema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>%0ACo-authored-by: akshatnema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>%0ACo-authored-by: akshatnema <[email protected]>
Co-authored-by: Ansh Goyal <[email protected]>
Co-authored-by: Ansh Goyal <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>%0ACo-authored-by: akshatnema <[email protected]>
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2710--asyncapi-website.netlify.app/ |
Confirming stuff looks good on my end and the docs look normal ✌🏽🪄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Co-authored-by: Akshat Nema <[email protected]>%0ACo-authored-by: Quetzalli <[email protected]>
some strange duplicate at https://deploy-preview-2710--asyncapi-website.netlify.app/finance that is not on prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!✅
Co-authored-by: Ansh Goyal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The website looks great. Some reported issues under the ticket #2924 doesn't seem like a blocker for this PR and can be tackled under the separate PRs after merging it into master
.
🚢
We need final approval from @derberg @alequetzalli. |
Since @derberg is OOTO and @alequetzalli @anshgoyalevil approved it previously, I'm going to merge it manually now. Hopefully, it doesn't break anything 🤞 |
Description
This PR is initiated to merge the updated changes from
master
tomigrate-ts
. Hence, no review is required until this is ready for merging in master.Related issue(s)