style: reduce company logo size on casestudy/[id] page #2728
Conversation
RamGoel
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2728--asyncapi-website.netlify.app/ |
|
This new indentation doesn't look consistent with the one we had earlier:
|
|
Also, would request you to wait for a triager to approve the issue before starting to work on it :) |
Approve? you mean 'to assign'? |
|
@RamGoel It doesn't look good in mobile view and IMO we don't need a change like this |
|
@RamGoel we can decrease the size of the company image which will look better |
yes sure. |
@sambhavgupta0705 I decreased the image size from |
|
Hey guys! Could you please review this. |
@sambhavgupta0705 as @anshgoyalevil suggested that the indentation earlier was not looking good. so I added this Here is updated indentation, this is same as we have earlier, that is why you aren't able to notice
|
pages/casestudies/[id].js
Outdated
| const typeStyle = | ||
| level === 0 ? "heading-lg" : level === 1 ? "heading-md" : "heading-sm"; | ||
|
|
||
| return content.map((item) => { | ||
| return ( | ||
| <div | ||
| className="mt-10" | ||
| className={`mt-10 mx-auto ${!isAgain?'w-11/12':''}`} |
There was a problem hiding this comment.
@RamGoel I am not able to understand the use of isAgain
So please remove it
|
@RamGoel just decrease the size of the image for this PR |
pages/casestudies/[id].js
Outdated
| @@ -17,7 +17,7 @@ const renderContent = (content, allComponents, level) => { | |||
| return content.map((item) => { | |||
| return ( | |||
| <div | |||
| className="mt-10" | |||
| className={`mt-10 mx-auto w-11/12`} | |||
There was a problem hiding this comment.
Rewrite this in conventional tailwind syntax as it was written previously
There was a problem hiding this comment.
you want to remove mx-auto w-11/12 as well? or just remove {} as there is no condition checking anymore?
|
@RamGoel you have made the changes in indentation again |
The whole idea of this PR is fixing the spacing, so I used That is why I had added the |
|
This is the current indentation we don't want any change in this |
|
For me it looks like this, on Win11, Chrome Zoom 100% . That was the reason I raised the PR. on 90% Zoom it looks good. but on 100% it sticks too much on left |
|
@RamGoel in this PR the image size has been decreased correctly but the indentation of the points has been changes which we don't want Please revert this change |
|
/rtm |
anshgoyalevil
changed the title
Description
/casestudies/[id]page and replaces any fixed width with relative width in tailwind classes.Related issue(s)
Resolves #2727
Preview