Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve message.md #2966

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

quetzalliwrites
Copy link
Member

Resolves: #2934.

@quetzalliwrites quetzalliwrites added 🐞 docs bug area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels May 15, 2024
@quetzalliwrites quetzalliwrites self-assigned this May 15, 2024
Copy link

netlify bot commented May 15, 2024

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit a2e784e
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/664bfb1555d4410007612bc6
😎 Deploy Preview https://deploy-preview-2966--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented May 15, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-2966--asyncapi-website.netlify.app/

Copy link
Collaborator

@J0SAL J0SAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshatnema
Copy link
Member

@alequetzalli Do you need my help here? 😅

@quetzalliwrites
Copy link
Member Author

Hey @akshatnema, thank you for asking 😸 ... yes, I can't merge; still shows as "merging is blocked."

Can you merge for me?

@akshatnema akshatnema merged commit 9b43a90 into master May 22, 2024
23 checks passed
@akshatnema akshatnema deleted the alequetzalli-improve-message-concepts branch May 22, 2024 06:38
@akshatnema
Copy link
Member

akshatnema commented May 22, 2024

@alequetzalli please make sure that you don't make feature branches inside the asyncapi/website repo. Instead make PRs from your forked repo only. Making feature branches in the repo can be quite confusing for other contributors as well and we only make feature branches if we need to spilt our feature changes into multiple PRs and do the testing of those changes in separate website preview (instead of doing it in production).

@quetzalliwrites
Copy link
Member Author

Hey @akshatnema, wow, I didn't realize I had created a feature branch! 😄 Sorry about that, thanks for explaining my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 🐞 docs bug
Projects
Status: Community PR under Review 🧐
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: Confusing/misleading sentence on https://www.asyncapi.com/docs/concepts/message
6 participants