-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add cheatsheet to repo to better maintain it long term #2983
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2983--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I see this is a temp fix, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Github can't preview/download the PDF inside the Github UI, then what is the purpose of adding it as a file inside repo?
@@ -69,3 +69,4 @@ https://www.asyncapi.io/* https://www.asyncapi.com/:splat 301! | |||
|
|||
# Additional redirection | |||
/community/meetings /community/events 301! | |||
/cheatsheet https://github.com/asyncapi/website/tree/master/cheatsheet 302! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be nice if we add the /cheatsheet
link as part of the Footer and README as well? It will be easily accessible for the users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should be part of #2982
for now, I gave away a lot of printed cheat sheets where we have QR code to this link, and for now, it fails for people 😅
/rtm |
"temporary" solution related to #2982