Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cheatsheet to repo to better maintain it long term #2983

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

derberg
Copy link
Member

@derberg derberg commented May 21, 2024

"temporary" solution related to #2982

Copy link

netlify bot commented May 21, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 52cb234
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6666b85652e71b0007aff0d8
😎 Deploy Preview https://deploy-preview-2983--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented May 21, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 36
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-2983--asyncapi-website.netlify.app/

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I see this is a temp fix, LGTM!

Copy link
Member

@akshatnema akshatnema May 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Github can't preview/download the PDF inside the Github UI, then what is the purpose of adding it as a file inside repo?

@@ -69,3 +69,4 @@ https://www.asyncapi.io/* https://www.asyncapi.com/:splat 301!

# Additional redirection
/community/meetings /community/events 301!
/cheatsheet https://github.com/asyncapi/website/tree/master/cheatsheet 302!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be nice if we add the /cheatsheet link as part of the Footer and README as well? It will be easily accessible for the users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be part of #2982

for now, I gave away a lot of printed cheat sheets where we have QR code to this link, and for now, it fails for people 😅

@derberg derberg requested a review from akshatnema May 31, 2024 19:38
@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 9b0e272 into asyncapi:master Jun 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants