Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify error handling in build-dashboard.js #3305

Open
coderabbitai bot opened this issue Oct 20, 2024 · 4 comments
Open

Simplify error handling in build-dashboard.js #3305

coderabbitai bot opened this issue Oct 20, 2024 · 4 comments
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2024

As discussed in PR #3304 (comment), @akshatnema agreed to improve the error handling by throwing errors directly instead of using Promise.reject(e); in the build-dashboard.js script.

We should update the error handling code to throw errors directly, making the asynchronous functions more idiomatic and easier to read.

Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@lakshaydewan
Copy link

Working on same will be raising a PR soon..

lakshaydewan added a commit to lakshaydewan/website that referenced this issue Oct 21, 2024
@lakshaydewan
Copy link

lakshaydewan commented Oct 21, 2024

PR #3310 fixes the issue needs a review though..

@yuvrajkarna2717
Copy link

Hello, I noticed this issue and would like to contribute. Is it still open for work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants