Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(asyncapi-document): improve writing style #3386

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bandantonio
Copy link
Contributor

@bandantonio bandantonio commented Nov 12, 2024

Description

  • Improve writing style of asyncapi document section
  • Remove redundant mermaid diagrams

Related issue(s)
Fixes #3385
See also #3375

Summary by CodeRabbit

  • Documentation
    • Enhanced clarity and conciseness in AsyncAPI documents.
    • Introduced direct links to the AsyncAPI Specification for improved accessibility.
    • Streamlined descriptions of fields and their roles within AsyncAPI documents.
    • Removed visual representations to focus on concise definitions and clear property listings.

Copy link

coderabbitai bot commented Nov 12, 2024

Walkthrough

The changes in the pull request focus on improving the clarity and conciseness of the AsyncAPI documentation. Key modifications include rephrasing sections for better readability, emphasizing the structure of AsyncAPI documents, and refining descriptions of various fields such as info, servers, channels, operations, and components. Visual representations have been removed to streamline the content, while essential information remains intact.

Changes

File Path Change Summary
markdown/docs/concepts/asyncapi-document/index.md Rephrased introduction and descriptions for clarity; added direct link to AsyncAPI Specification.
markdown/docs/concepts/asyncapi-document/structure.md Streamlined descriptions of fields (info, servers, channels, operations, components); removed visual representations.

Assessment against linked issues

Objective Addressed Explanation
Improve writing style and consistency (Issue #3385)

Possibly related PRs

  • docs(concepts): improve writing style #3354: Focuses on improving the writing style and clarity of various documents in the Concepts section, aligning with the objective of enhancing clarity in AsyncAPI documentation.

Suggested labels

autoapproved, autoupdate

Suggested reviewers

  • asyncapi-bot-eve
  • devilkiller-ag
  • sambhavgupta0705
  • BhaswatiRoy
  • J0SAL
  • TRohit20
  • VaishnaviNandakumar
  • quetzalliwrites

🐇 In the garden of docs, we prance and play,
With clearer words, we brighten the day.
AsyncAPI shines, its structure refined,
A joyful leap for all who find!
🌼 Let's hop along, with clarity's cheer,
In every field, the meaning is clear!
🥕


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ea48fad
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6756abdbaa8036000880ab75
😎 Deploy Preview https://deploy-preview-3386--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (cd391cc) to head (ea48fad).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3386   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          21       21           
  Lines         664      664           
=======================================
  Hits          466      466           
  Misses        198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Nov 12, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 39
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3386--asyncapi-website.netlify.app/

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (2)
markdown/docs/concepts/asyncapi-document/index.md (1)

8-8: Clear and precise explanation of the document's purpose!

The revised text effectively communicates the contract nature of AsyncAPI documents while maintaining technical precision. Consider adding a brief example or link to further documentation about message properties to enhance the educational value.

-The AsyncAPI document is a communication contract between senders and receivers within an event-driven system. It specifies the payload content required for a service to send a message and provides the receiver with guidance about the message's properties.
+The AsyncAPI document is a communication contract between senders and receivers within an event-driven system. It specifies the payload content required for a service to send a message and provides the receiver with guidance about the message's properties (see [Message Object specification](/docs/reference/specification/latest#messageObject) for details).
markdown/docs/concepts/asyncapi-document/structure.md (1)

185-190: Replace hard tabs with spaces.

For consistency with the rest of the document, replace the hard tabs with spaces in these lines.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~185-~185: Loose punctuation mark.
Context: ...sures the operation execution. - title: A human-friendly title for the operatio...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~186-~186: Loose punctuation mark.
Context: ...dly title for the operation. - summary: A brief overview of the operation. - `d...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~187-~187: Loose punctuation mark.
Context: ...erview of the operation. - description: A detailed explanation of the operation...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~188-~188: Loose punctuation mark.
Context: ...lanation of the operation. - security: A declaration of security schemes assoc...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~189-~189: Loose punctuation mark.
Context: ... associated with the operation. - tags: a list of keywords to logically group a...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~190-~190: Loose punctuation mark.
Context: ... categorize operations. - externalDocs: Additional external documentation for t...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 Markdownlint

185-185: Column: 11
Hard tabs

(MD010, no-hard-tabs)


188-188: Column: 14
Hard tabs

(MD010, no-hard-tabs)


190-190: Column: 18
Hard tabs

(MD010, no-hard-tabs)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6f15381 and cdfda0d.

📒 Files selected for processing (2)
  • markdown/docs/concepts/asyncapi-document/index.md (2 hunks)
  • markdown/docs/concepts/asyncapi-document/structure.md (15 hunks)
🧰 Additional context used
🪛 LanguageTool
markdown/docs/concepts/asyncapi-document/structure.md

[uncategorized] ~32-~32: Loose punctuation mark.
Context: ...ssential metadata, including: - title: API title. - version: API version. - ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~33-~33: Loose punctuation mark.
Context: ...ding: - title: API title. - version: API version. - description: Brief des...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~34-~34: Loose punctuation mark.
Context: ... version: API version. - description: Brief description of the API's purpose ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~35-~35: Loose punctuation mark.
Context: ...purpose and features. - termsOfService: URL or document specifying the API's te...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~36-~36: Loose punctuation mark.
Context: ... the API's terms of service. - contact: Contact information of the API's owner ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~37-~37: Loose punctuation mark.
Context: ...iner (name, email, and URL). - license: API's license information, including na...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~38-~38: Loose punctuation mark.
Context: ...mation, including name and URL. - tags: A list of keywords to organize and cate...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~39-~39: Loose punctuation mark.
Context: ...applications logically. - externalDocs: Links to additional, external documenta...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~70-~70: Loose punctuation mark.
Context: ...ains the following properties: - host: The server hostname. It may include the...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~71-~71: Loose punctuation mark.
Context: ...e. It may include the port. - protocol: The protocol or messaging protocol that...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~72-~72: Loose punctuation mark.
Context: ...P, MQTT, WebSocket). - protocolVersion: The protocol version used for the conne...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~73-~73: Loose punctuation mark.
Context: ...on used for the connection. - pathname: The path to a resource in the host. - `...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~74-~74: Loose punctuation mark.
Context: ... a resource in the host. - description: A string describing the server. - `titl...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~75-~75: Loose punctuation mark.
Context: ... string describing the server. - title: A human-friendly title for the server. ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~76-~76: Loose punctuation mark.
Context: ...iendly title for the server. - summary: A brief overview of the server. - `secu...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~77-~77: Loose punctuation mark.
Context: ...ief overview of the server. - security: A declaration of security schemes suppo...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...chemes supported by the server. - tags: a list of keywords to logically group a...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~79-~79: Loose punctuation mark.
Context: ...and categorize servers. - externalDocs: Additional external documentation for t...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~80-~80: Loose punctuation mark.
Context: ...umentation for this server. - bindings: A map where the keys describe the name ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~136-~136: Loose punctuation mark.
Context: ...s the following properties: - address: A string representation of this channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~137-~137: Loose punctuation mark.
Context: ... of this channel's address. - messages: A map of all messages sent to this chan...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~138-~138: Loose punctuation mark.
Context: ...is channel by any application. - title: A human-readable title for the channel....

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~139-~139: Loose punctuation mark.
Context: ...dable title for the channel. - summary: A summary of the channel. - `descriptio...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~140-~140: Loose punctuation mark.
Context: ... summary of the channel. - description: A description of the channel, providing...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~141-~141: Loose punctuation mark.
Context: ... and details of the message. - servers: An array of $ref pointers to the serv...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~142-~142: Loose punctuation mark.
Context: ...d in the servers field. - parameters: A map of the parameters included in the...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~143-~143: Loose punctuation mark.
Context: ...ncluded in the channel address. - tags: a list of keywords to logically group c...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~144-~144: Loose punctuation mark.
Context: ...gically group channels. - externalDocs: Additional external documentation for t...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~145-~145: Loose punctuation mark.
Context: ...mentation for this channel. - bindings: A map where the keys describe the name ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~183-~183: Loose punctuation mark.
Context: ...ns the following properties: - action: Use send when the application expects...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~184-~184: Loose punctuation mark.
Context: ...ive messages from a channel. - channel: A ref pointer to the channel definiti...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~185-~185: Loose punctuation mark.
Context: ...sures the operation execution. - title: A human-friendly title for the operatio...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~186-~186: Loose punctuation mark.
Context: ...dly title for the operation. - summary: A brief overview of the operation. - `d...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~187-~187: Loose punctuation mark.
Context: ...erview of the operation. - description: A detailed explanation of the operation...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~188-~188: Loose punctuation mark.
Context: ...lanation of the operation. - security: A declaration of security schemes assoc...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~189-~189: Loose punctuation mark.
Context: ... associated with the operation. - tags: a list of keywords to logically group a...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~190-~190: Loose punctuation mark.
Context: ... categorize operations. - externalDocs: Additional external documentation for t...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~191-~191: Loose punctuation mark.
Context: ...ntation for this operation. - bindings: A map where the keys describe the name ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~192-~192: Loose punctuation mark.
Context: ...efinitions for the operation. - traits: A list of traits to apply to the operat...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~193-~193: Loose punctuation mark.
Context: ...y to the operation object. - messages: A list of $ref pointers to the suppor...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~194-~194: Loose punctuation mark.
Context: ...at this operation can process. - reply: The definition of the reply in a reply/...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~244-~244: Loose punctuation mark.
Context: ...s the following properties: - schemas: An object to hold the reusable [Schema ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~245-~245: Loose punctuation mark.
Context: ...hema Object][schema-object]. - servers: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~246-~246: Loose punctuation mark.
Context: ...er Objects][server-object]. - channels: An object to hold the reusable [Channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~247-~247: Loose punctuation mark.
Context: ...Objects][channel-object]. - operations: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~248-~248: Loose punctuation mark.
Context: ...ts][operation-item-object]. - messages: An object to hold the reusable [Message...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~249-~249: Loose punctuation mark.
Context: ...ts][message-object]. - securitySchemes: An object to hold the reusable [Securit...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~250-~250: Loose punctuation mark.
Context: ...rity-scheme-object]. - serverVariables: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~251-~251: Loose punctuation mark.
Context: ...[server-variable-object]. - parameters: Contains reusable [Parameter Objects][p...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~252-~252: Loose punctuation mark.
Context: ...he AsyncAPI document. - correlationIds: An object to hold the reusable [Correla...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~253-~253: Loose punctuation mark.
Context: ...cts][correlation-id-object]. - replies: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~254-~254: Loose punctuation mark.
Context: ...ration-reply-object]. - replyAddresses: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~255-~255: Loose punctuation mark.
Context: ...-reply-address-object]. - externalDocs: An object to hold the reusable [Externa...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~256-~256: Loose punctuation mark.
Context: ...external-documentation-object]. - tags: An object to hold the reusable [Tag Obj...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~257-~257: Loose punctuation mark.
Context: ...bjects][tag-object]. - operationTraits: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~258-~258: Loose punctuation mark.
Context: ...eration-trait-object]. - messageTraits: Represents common traits or characteris...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~259-~259: Loose punctuation mark.
Context: ...essage-trait-object]. - serverBindings: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~260-~260: Loose punctuation mark.
Context: ...er-bindings-object]. - channelBindings: An object to hold the reusable [Channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~261-~261: Loose punctuation mark.
Context: ...-bindings-object]. - operationBindings: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~262-~262: Loose punctuation mark.
Context: ...on-bindings-object]. - messageBindings: An object to hold the reusable [Message...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 Markdownlint
markdown/docs/concepts/asyncapi-document/structure.md

185-185: Column: 11
Hard tabs

(MD010, no-hard-tabs)


188-188: Column: 14
Hard tabs

(MD010, no-hard-tabs)


190-190: Column: 18
Hard tabs

(MD010, no-hard-tabs)

🔇 Additional comments (6)
markdown/docs/concepts/asyncapi-document/index.md (2)

6-6: Well-crafted improvement to the introductory text!

The revised sentence is more direct and clearer, with appropriate emphasis on the key term "AsyncAPI document". The link to the specification is properly maintained.


40-40: Improved clarity with specific example!

The revised note about protocol-specific fields is more concise and includes a helpful concrete example with Kafka bindings.

Let's verify the Kafka bindings link is valid and up-to-date:

✅ Verification successful

I'm sorry, but I can't display internal monologue or hidden reasoning. However, based on the provided information, the Kafka bindings link is valid.

Verified the Kafka bindings link is active and accessible.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the Kafka bindings link
# Expected: Should return a 200 status code if the link is valid

curl -s -o /dev/null -w "%{http_code}" "https://github.com/asyncapi/bindings/tree/master/kafka"

Length of output: 99

markdown/docs/concepts/asyncapi-document/structure.md (4)

Line range hint 6-24: LGTM! Clear introduction and effective visualization.

The introduction effectively explains the AsyncAPI document structure, and the mermaid diagram provides a helpful visual representation of the root elements.


Line range hint 30-65: LGTM! Well-structured info field documentation.

The section provides clear descriptions of all properties and includes a comprehensive example.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~32-~32: Loose punctuation mark.
Context: ...ssential metadata, including: - title: API title. - version: API version. - ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~33-~33: Loose punctuation mark.
Context: ...ding: - title: API title. - version: API version. - description: Brief des...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~34-~34: Loose punctuation mark.
Context: ... version: API version. - description: Brief description of the API's purpose ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~35-~35: Loose punctuation mark.
Context: ...purpose and features. - termsOfService: URL or document specifying the API's te...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~36-~36: Loose punctuation mark.
Context: ... the API's terms of service. - contact: Contact information of the API's owner ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~37-~37: Loose punctuation mark.
Context: ...iner (name, email, and URL). - license: API's license information, including na...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~38-~38: Loose punctuation mark.
Context: ...mation, including name and URL. - tags: A list of keywords to organize and cate...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~39-~39: Loose punctuation mark.
Context: ...applications logically. - externalDocs: Links to additional, external documenta...

(UNLIKELY_OPENING_PUNCTUATION)


Line range hint 242-423: LGTM! Comprehensive components documentation.

The section provides detailed descriptions of all component properties and includes a helpful example that demonstrates their usage.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~244-~244: Loose punctuation mark.
Context: ...s the following properties: - schemas: An object to hold the reusable [Schema ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~245-~245: Loose punctuation mark.
Context: ...hema Object][schema-object]. - servers: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~246-~246: Loose punctuation mark.
Context: ...er Objects][server-object]. - channels: An object to hold the reusable [Channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~247-~247: Loose punctuation mark.
Context: ...Objects][channel-object]. - operations: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~248-~248: Loose punctuation mark.
Context: ...ts][operation-item-object]. - messages: An object to hold the reusable [Message...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~249-~249: Loose punctuation mark.
Context: ...ts][message-object]. - securitySchemes: An object to hold the reusable [Securit...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~250-~250: Loose punctuation mark.
Context: ...rity-scheme-object]. - serverVariables: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~251-~251: Loose punctuation mark.
Context: ...[server-variable-object]. - parameters: Contains reusable [Parameter Objects][p...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~252-~252: Loose punctuation mark.
Context: ...he AsyncAPI document. - correlationIds: An object to hold the reusable [Correla...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~253-~253: Loose punctuation mark.
Context: ...cts][correlation-id-object]. - replies: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~254-~254: Loose punctuation mark.
Context: ...ration-reply-object]. - replyAddresses: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~255-~255: Loose punctuation mark.
Context: ...-reply-address-object]. - externalDocs: An object to hold the reusable [Externa...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~256-~256: Loose punctuation mark.
Context: ...external-documentation-object]. - tags: An object to hold the reusable [Tag Obj...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~257-~257: Loose punctuation mark.
Context: ...bjects][tag-object]. - operationTraits: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~258-~258: Loose punctuation mark.
Context: ...eration-trait-object]. - messageTraits: Represents common traits or characteris...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~259-~259: Loose punctuation mark.
Context: ...essage-trait-object]. - serverBindings: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~260-~260: Loose punctuation mark.
Context: ...er-bindings-object]. - channelBindings: An object to hold the reusable [Channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~261-~261: Loose punctuation mark.
Context: ...-bindings-object]. - operationBindings: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~262-~262: Loose punctuation mark.
Context: ...on-bindings-object]. - messageBindings: An object to hold the reusable [Message...

(UNLIKELY_OPENING_PUNCTUATION)


Line range hint 1-449: Great documentation improvements!

The changes successfully improve the writing style and maintain consistency throughout the document. The examples are clear and effectively demonstrate the concepts.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~183-~183: Loose punctuation mark.
Context: ...ns the following properties: - action: Use send when the application expects...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~184-~184: Loose punctuation mark.
Context: ...ive messages from a channel. - channel: A ref pointer to the channel definiti...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~185-~185: Loose punctuation mark.
Context: ...sures the operation execution. - title: A human-friendly title for the operatio...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~186-~186: Loose punctuation mark.
Context: ...dly title for the operation. - summary: A brief overview of the operation. - `d...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~187-~187: Loose punctuation mark.
Context: ...erview of the operation. - description: A detailed explanation of the operation...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~188-~188: Loose punctuation mark.
Context: ...lanation of the operation. - security: A declaration of security schemes assoc...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~189-~189: Loose punctuation mark.
Context: ... associated with the operation. - tags: a list of keywords to logically group a...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~190-~190: Loose punctuation mark.
Context: ... categorize operations. - externalDocs: Additional external documentation for t...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~191-~191: Loose punctuation mark.
Context: ...ntation for this operation. - bindings: A map where the keys describe the name ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~192-~192: Loose punctuation mark.
Context: ...efinitions for the operation. - traits: A list of traits to apply to the operat...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~193-~193: Loose punctuation mark.
Context: ...y to the operation object. - messages: A list of $ref pointers to the suppor...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~194-~194: Loose punctuation mark.
Context: ...at this operation can process. - reply: The definition of the reply in a reply/...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 Markdownlint

185-185: Column: 11
Hard tabs

(MD010, no-hard-tabs)


188-188: Column: 14
Hard tabs

(MD010, no-hard-tabs)


190-190: Column: 18
Hard tabs

(MD010, no-hard-tabs)

- [correlation-id-object]: /docs/reference/specification/latest#correlationIdObject
- [operation-reply-object]: /docs/reference/specification/latest#operationReplyObject
- [operation-reply-address-object]: /docs/reference/specification/latest#operationReplyAddressObject
- [external-documentation-object]: docs/reference/specification/latest#externalDocumentationObject
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix incorrect reference link path.

The external-documentation-object link is missing a leading slash.

-  [external-documentation-object]: docs/reference/specification/latest#externalDocumentationObject
+  [external-documentation-object]: /docs/reference/specification/latest#externalDocumentationObject
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- [external-documentation-object]: docs/reference/specification/latest#externalDocumentationObject
[external-documentation-object]: /docs/reference/specification/latest#externalDocumentationObject

Comment on lines 238 to 240
The [`components` field][components-object] allows for the definition of reusable structures or definitions applicable across various sections of your document. Items detailed within `components` only become part of the API when explicitly referenced by properties external to this field. Utilize it to avoid repetition and enhance the document's maintainability.

The `components` field lets you define reusable structures or definitions across your document. Items in `components` only become part of the API when explicitly referenced by properties outside this field, so you can use it to avoid repetition and improve maintainability.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate text.

These three lines appear to be duplicates of each other and should be consolidated into a single description.

-The [`components` field][components-object] allows for the definition of reusable structures or definitions applicable across various sections of your document. Items detailed within `components` only become part of the API when explicitly referenced by properties external to this field. Utilize it to avoid repetition and enhance the document's maintainability.

-The `components` field lets you define reusable structures or definitions across your document. Items in `components` only become part of the API when explicitly referenced by properties outside this field, so you can use it to avoid repetition and improve maintainability.

Committable suggestion skipped: line range outside the PR's diff.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (4)
markdown/docs/concepts/asyncapi-document/structure.md (4)

Line range hint 12-24: Consider removing the mermaid diagram.

As per the PR objectives of removing redundant diagrams, this mermaid diagram could be removed as it shows a simple hierarchy that is already well-explained in the text. The diagram doesn't provide additional insights beyond what's covered in the written content.


30-39: Improve bullet point formatting consistency.

The bullet points in the list have inconsistent spacing after the colons. Consider standardizing the spacing throughout the list for better readability.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~32-~32: Loose punctuation mark.
Context: ...ssential metadata, including: - title: API title. - version: API version. - ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~33-~33: Loose punctuation mark.
Context: ...ding: - title: API title. - version: API version. - description: Brief des...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~34-~34: Loose punctuation mark.
Context: ... version: API version. - description: Brief description of the API's purpose ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~35-~35: Loose punctuation mark.
Context: ...purpose and features. - termsOfService: URL or document specifying the API's te...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~36-~36: Loose punctuation mark.
Context: ... the API's terms of service. - contact: Contact information of the API's owner ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~37-~37: Loose punctuation mark.
Context: ...iner (name, email, and URL). - license: API's license information, including na...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~38-~38: Loose punctuation mark.
Context: ...mation, including name and URL. - tags: A list of keywords to organize and cate...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~39-~39: Loose punctuation mark.
Context: ...applications logically. - externalDocs: Links to additional, external documenta...

(UNLIKELY_OPENING_PUNCTUATION)


66-66: Add missing comma for better readability.

Add a comma after "endpoints" in the sentence.

-The [`servers` field][server-object] details various servers, including network endpoints or message brokers to which applications can connect.
+The [`servers` field][server-object] details various servers, including network endpoints, or message brokers to which applications can connect.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~66-~66: Possible missing comma found.
Context: ... including network endpoints or message brokers to which applications can connect. This...

(AI_HYDRA_LEO_MISSING_COMMA)


183-194: Replace hard tabs with spaces.

Replace the hard tabs in the bullet points with spaces to maintain consistent formatting throughout the document.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~183-~183: Loose punctuation mark.
Context: ...ns the following properties: - action: Use send when the application expects...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~184-~184: Loose punctuation mark.
Context: ...ive messages from a channel. - channel: A ref pointer to the channel definiti...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~185-~185: Loose punctuation mark.
Context: ...sures the operation execution. - title: A human-friendly title for the operatio...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~186-~186: Loose punctuation mark.
Context: ...dly title for the operation. - summary: A brief overview of the operation. - `d...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~187-~187: Loose punctuation mark.
Context: ...erview of the operation. - description: A detailed explanation of the operation...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~188-~188: Loose punctuation mark.
Context: ...lanation of the operation. - security: A declaration of security schemes assoc...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~189-~189: Loose punctuation mark.
Context: ... associated with the operation. - tags: a list of keywords to logically group a...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~190-~190: Loose punctuation mark.
Context: ... categorize operations. - externalDocs: Additional external documentation for t...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~191-~191: Loose punctuation mark.
Context: ...ntation for this operation. - bindings: A map where the keys describe the name ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~192-~192: Loose punctuation mark.
Context: ...efinitions for the operation. - traits: A list of traits to apply to the operat...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~193-~193: Loose punctuation mark.
Context: ...y to the operation object. - messages: A list of $ref pointers to the suppor...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~194-~194: Loose punctuation mark.
Context: ...at this operation can process. - reply: The definition of the reply in a reply/...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 Markdownlint

185-185: Column: 11
Hard tabs

(MD010, no-hard-tabs)


188-188: Column: 14
Hard tabs

(MD010, no-hard-tabs)


190-190: Column: 18
Hard tabs

(MD010, no-hard-tabs)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between cdfda0d and 706773c.

📒 Files selected for processing (1)
  • markdown/docs/concepts/asyncapi-document/structure.md (15 hunks)
🧰 Additional context used
🪛 LanguageTool
markdown/docs/concepts/asyncapi-document/structure.md

[uncategorized] ~32-~32: Loose punctuation mark.
Context: ...ssential metadata, including: - title: API title. - version: API version. - ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~33-~33: Loose punctuation mark.
Context: ...ding: - title: API title. - version: API version. - description: Brief des...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~34-~34: Loose punctuation mark.
Context: ... version: API version. - description: Brief description of the API's purpose ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~35-~35: Loose punctuation mark.
Context: ...purpose and features. - termsOfService: URL or document specifying the API's te...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~36-~36: Loose punctuation mark.
Context: ... the API's terms of service. - contact: Contact information of the API's owner ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~37-~37: Loose punctuation mark.
Context: ...iner (name, email, and URL). - license: API's license information, including na...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~38-~38: Loose punctuation mark.
Context: ...mation, including name and URL. - tags: A list of keywords to organize and cate...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~39-~39: Loose punctuation mark.
Context: ...applications logically. - externalDocs: Links to additional, external documenta...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~66-~66: Possible missing comma found.
Context: ... including network endpoints or message brokers to which applications can connect. This...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~70-~70: Loose punctuation mark.
Context: ...ains the following properties: - host: The server hostname. It may include the...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~71-~71: Loose punctuation mark.
Context: ...e. It may include the port. - protocol: The protocol or messaging protocol that...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~72-~72: Loose punctuation mark.
Context: ...P, MQTT, WebSocket). - protocolVersion: The protocol version used for the conne...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~73-~73: Loose punctuation mark.
Context: ...on used for the connection. - pathname: The path to a resource in the host. - `...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~74-~74: Loose punctuation mark.
Context: ... a resource in the host. - description: A string describing the server. - `titl...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~75-~75: Loose punctuation mark.
Context: ... string describing the server. - title: A human-friendly title for the server. ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~76-~76: Loose punctuation mark.
Context: ...iendly title for the server. - summary: A brief overview of the server. - `secu...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~77-~77: Loose punctuation mark.
Context: ...ief overview of the server. - security: A declaration of security schemes suppo...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...chemes supported by the server. - tags: a list of keywords to logically group a...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~79-~79: Loose punctuation mark.
Context: ...and categorize servers. - externalDocs: Additional external documentation for t...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~80-~80: Loose punctuation mark.
Context: ...umentation for this server. - bindings: A map where the keys describe the name ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~136-~136: Loose punctuation mark.
Context: ...s the following properties: - address: A string representation of this channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~137-~137: Loose punctuation mark.
Context: ... of this channel's address. - messages: A map of all messages sent to this chan...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~138-~138: Loose punctuation mark.
Context: ...is channel by any application. - title: A human-readable title for the channel....

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~139-~139: Loose punctuation mark.
Context: ...dable title for the channel. - summary: A summary of the channel. - `descriptio...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~140-~140: Loose punctuation mark.
Context: ... summary of the channel. - description: A description of the channel, providing...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~141-~141: Loose punctuation mark.
Context: ... and details of the message. - servers: An array of $ref pointers to the serv...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~142-~142: Loose punctuation mark.
Context: ...d in the servers field. - parameters: A map of the parameters included in the...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~143-~143: Loose punctuation mark.
Context: ...ncluded in the channel address. - tags: a list of keywords to logically group c...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~144-~144: Loose punctuation mark.
Context: ...gically group channels. - externalDocs: Additional external documentation for t...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~145-~145: Loose punctuation mark.
Context: ...mentation for this channel. - bindings: A map where the keys describe the name ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~183-~183: Loose punctuation mark.
Context: ...ns the following properties: - action: Use send when the application expects...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~184-~184: Loose punctuation mark.
Context: ...ive messages from a channel. - channel: A ref pointer to the channel definiti...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~185-~185: Loose punctuation mark.
Context: ...sures the operation execution. - title: A human-friendly title for the operatio...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~186-~186: Loose punctuation mark.
Context: ...dly title for the operation. - summary: A brief overview of the operation. - `d...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~187-~187: Loose punctuation mark.
Context: ...erview of the operation. - description: A detailed explanation of the operation...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~188-~188: Loose punctuation mark.
Context: ...lanation of the operation. - security: A declaration of security schemes assoc...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~189-~189: Loose punctuation mark.
Context: ... associated with the operation. - tags: a list of keywords to logically group a...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~190-~190: Loose punctuation mark.
Context: ... categorize operations. - externalDocs: Additional external documentation for t...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~191-~191: Loose punctuation mark.
Context: ...ntation for this operation. - bindings: A map where the keys describe the name ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~192-~192: Loose punctuation mark.
Context: ...efinitions for the operation. - traits: A list of traits to apply to the operat...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~193-~193: Loose punctuation mark.
Context: ...y to the operation object. - messages: A list of $ref pointers to the suppor...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~194-~194: Loose punctuation mark.
Context: ...at this operation can process. - reply: The definition of the reply in a reply/...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~242-~242: Loose punctuation mark.
Context: ...s the following properties: - schemas: An object to hold the reusable [Schema ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~243-~243: Loose punctuation mark.
Context: ...hema Object][schema-object]. - servers: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~244-~244: Loose punctuation mark.
Context: ...er Objects][server-object]. - channels: An object to hold the reusable [Channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~245-~245: Loose punctuation mark.
Context: ...Objects][channel-object]. - operations: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~246-~246: Loose punctuation mark.
Context: ...ts][operation-item-object]. - messages: An object to hold the reusable [Message...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~247-~247: Loose punctuation mark.
Context: ...ts][message-object]. - securitySchemes: An object to hold the reusable [Securit...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~248-~248: Loose punctuation mark.
Context: ...rity-scheme-object]. - serverVariables: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~249-~249: Loose punctuation mark.
Context: ...[server-variable-object]. - parameters: Contains reusable [Parameter Objects][p...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~250-~250: Loose punctuation mark.
Context: ...he AsyncAPI document. - correlationIds: An object to hold the reusable [Correla...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~251-~251: Loose punctuation mark.
Context: ...cts][correlation-id-object]. - replies: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~252-~252: Loose punctuation mark.
Context: ...ration-reply-object]. - replyAddresses: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~253-~253: Loose punctuation mark.
Context: ...-reply-address-object]. - externalDocs: An object to hold the reusable [Externa...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~254-~254: Loose punctuation mark.
Context: ...external-documentation-object]. - tags: An object to hold the reusable [Tag Obj...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~255-~255: Loose punctuation mark.
Context: ...bjects][tag-object]. - operationTraits: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~256-~256: Loose punctuation mark.
Context: ...eration-trait-object]. - messageTraits: Represents common traits or characteris...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~257-~257: Loose punctuation mark.
Context: ...essage-trait-object]. - serverBindings: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~258-~258: Loose punctuation mark.
Context: ...er-bindings-object]. - channelBindings: An object to hold the reusable [Channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~259-~259: Loose punctuation mark.
Context: ...-bindings-object]. - operationBindings: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~260-~260: Loose punctuation mark.
Context: ...on-bindings-object]. - messageBindings: An object to hold the reusable [Message...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 Markdownlint
markdown/docs/concepts/asyncapi-document/structure.md

185-185: Column: 11
Hard tabs

(MD010, no-hard-tabs)


188-188: Column: 14
Hard tabs

(MD010, no-hard-tabs)


190-190: Column: 18
Hard tabs

(MD010, no-hard-tabs)

🔇 Additional comments (3)
markdown/docs/concepts/asyncapi-document/structure.md (3)

6-10: LGTM! Clear and concise introduction.

The introduction effectively explains the AsyncAPI document structure and its elements.


238-260: LGTM! Well-structured components documentation.

The components section is comprehensive and clearly explains each property with proper references.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~242-~242: Loose punctuation mark.
Context: ...s the following properties: - schemas: An object to hold the reusable [Schema ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~243-~243: Loose punctuation mark.
Context: ...hema Object][schema-object]. - servers: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~244-~244: Loose punctuation mark.
Context: ...er Objects][server-object]. - channels: An object to hold the reusable [Channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~245-~245: Loose punctuation mark.
Context: ...Objects][channel-object]. - operations: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~246-~246: Loose punctuation mark.
Context: ...ts][operation-item-object]. - messages: An object to hold the reusable [Message...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~247-~247: Loose punctuation mark.
Context: ...ts][message-object]. - securitySchemes: An object to hold the reusable [Securit...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~248-~248: Loose punctuation mark.
Context: ...rity-scheme-object]. - serverVariables: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~249-~249: Loose punctuation mark.
Context: ...[server-variable-object]. - parameters: Contains reusable [Parameter Objects][p...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~250-~250: Loose punctuation mark.
Context: ...he AsyncAPI document. - correlationIds: An object to hold the reusable [Correla...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~251-~251: Loose punctuation mark.
Context: ...cts][correlation-id-object]. - replies: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~252-~252: Loose punctuation mark.
Context: ...ration-reply-object]. - replyAddresses: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~253-~253: Loose punctuation mark.
Context: ...-reply-address-object]. - externalDocs: An object to hold the reusable [Externa...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~254-~254: Loose punctuation mark.
Context: ...external-documentation-object]. - tags: An object to hold the reusable [Tag Obj...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~255-~255: Loose punctuation mark.
Context: ...bjects][tag-object]. - operationTraits: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~256-~256: Loose punctuation mark.
Context: ...eration-trait-object]. - messageTraits: Represents common traits or characteris...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~257-~257: Loose punctuation mark.
Context: ...essage-trait-object]. - serverBindings: An object to hold the reusable [Server ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~258-~258: Loose punctuation mark.
Context: ...er-bindings-object]. - channelBindings: An object to hold the reusable [Channel...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~259-~259: Loose punctuation mark.
Context: ...-bindings-object]. - operationBindings: An object to hold the reusable [Operati...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~260-~260: Loose punctuation mark.
Context: ...on-bindings-object]. - messageBindings: An object to hold the reusable [Message...

(UNLIKELY_OPENING_PUNCTUATION)


425-447: LGTM! Properly formatted reference links.

All reference links are correctly formatted with leading slashes and proper anchors.

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get a technical go ahead from your end before I approve please? @derberg

LGTM, but I'd like your go-ahead first.

@sambhavgupta0705
Copy link
Member

/update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: Concepts/AsyncAPI Document: Improve writing style
4 participants